-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rewards bucket keeper logic + tests #3426
Conversation
snobbee
commented
Nov 6, 2023
•
edited
Loading
edited
- Add Rewards Bucket functionality to CLP Keeper.
- Add queries to rewards bucket list and single denom.
- Add unit tests.
Codecov Report
@@ Coverage Diff @@
## master #3426 +/- ##
==========================================
+ Coverage 43.35% 43.77% +0.42%
==========================================
Files 166 168 +2
Lines 15895 15987 +92
==========================================
+ Hits 6891 6999 +108
+ Misses 8591 8571 -20
- Partials 413 417 +4
|
list = append(list, val) | ||
} | ||
|
||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why it doesn't return any value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pgoos when calling return
it will return the variables that are defined in the signature of the function, you can see the return variables defined on the right:
(list []types.RewardsBucket)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMAZING work @snobbee 🚀