Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rewards bucket keeper logic + tests #3426

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

snobbee
Copy link
Contributor

@snobbee snobbee commented Nov 6, 2023

  • Add Rewards Bucket functionality to CLP Keeper.
  • Add queries to rewards bucket list and single denom.
  • Add unit tests.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #3426 (4276cd2) into master (0c63583) will increase coverage by 0.42%.
Report is 7 commits behind head on master.
The diff coverage is 70.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3426      +/-   ##
==========================================
+ Coverage   43.35%   43.77%   +0.42%     
==========================================
  Files         166      168       +2     
  Lines       15895    15987      +92     
==========================================
+ Hits         6891     6999     +108     
+ Misses       8591     8571      -20     
- Partials      413      417       +4     
Files Coverage Δ
app/app.go 94.08% <100.00%> (+3.97%) ⬆️
cmd/sifnoded/cmd/ibc-diag.go 15.74% <ø> (ø)
x/clp/keeper/rewards_bucket.go 100.00% <100.00%> (ø)
x/clp/types/codec.go 100.00% <ø> (ø)
x/clp/types/key_rewards_bucket.go 100.00% <100.00%> (ø)
x/clp/types/keys.go 84.21% <100.00%> (+0.87%) ⬆️
x/clp/types/querier.go 100.00% <ø> (ø)
x/dispensation/types/types.go 100.00% <100.00%> (ø)
x/ibctransfer/helpers/conversion_helper.go 37.19% <ø> (ø)
x/ibctransfer/keeper/msg_server.go 86.95% <ø> (ø)
... and 6 more

... and 2 files with indirect coverage changes

list = append(list, val)
}

return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why it doesn't return any value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pgoos when calling return it will return the variables that are defined in the signature of the function, you can see the return variables defined on the right:

(list []types.RewardsBucket)

Copy link
Contributor

@pgoos pgoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING work @snobbee 🚀

@snobbee snobbee merged commit 40bb2c3 into master Nov 7, 2023
9 checks passed
@snobbee snobbee deleted the feat/rewards-bucket-keeper branch November 7, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants