Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new CLP tx to add liquidity to rewards bucket #3427

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

snobbee
Copy link
Contributor

@snobbee snobbee commented Nov 7, 2023

  • add new CLP tx to add liquidity to rewards bucket
  • add rewards bucket keeper functions
  • add bank keeper mock object to mock bank keeper functions
  • add unit tests for rewards bucket keeper functions
  • add integration tests for the tx message
  • add REST post endpoint

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #3427 (03adcfa) into master (0c63583) will increase coverage by 0.11%.
Report is 8 commits behind head on master.
The diff coverage is 38.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3427      +/-   ##
==========================================
+ Coverage   43.35%   43.46%   +0.11%     
==========================================
  Files         166      175       +9     
  Lines       15895    16328     +433     
==========================================
+ Hits         6891     7097     +206     
- Misses       8591     8807     +216     
- Partials      413      424      +11     
Files Coverage Δ
app/app.go 94.08% <100.00%> (+3.97%) ⬆️
cmd/sifnoded/cmd/ibc-diag.go 15.74% <ø> (ø)
x/clp/types/codec.go 100.00% <100.00%> (ø)
x/clp/types/key_rewards_bucket.go 100.00% <100.00%> (ø)
x/clp/types/keys.go 84.21% <100.00%> (+0.87%) ⬆️
x/clp/types/querier.go 100.00% <ø> (ø)
x/dispensation/types/types.go 100.00% <100.00%> (ø)
x/ibctransfer/helpers/conversion_helper.go 37.19% <ø> (ø)
x/ibctransfer/keeper/msg_server.go 86.95% <ø> (ø)
app/setup_handlers.go 10.52% <0.00%> (+1.83%) ⬆️
... and 14 more

... and 2 files with indirect coverage changes

Copy link
Contributor

@pgoos pgoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM looks great 🚀

@snobbee snobbee merged commit f2ba094 into master Nov 8, 2023
8 of 9 checks passed
@snobbee snobbee deleted the feat/clp-tx-to-add-liq-to-rewards-bucket branch November 8, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants