Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase min gas price and min fee #3429

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

snobbee
Copy link
Contributor

@snobbee snobbee commented Nov 14, 2023

  • increase min gas price regardless of tx type
  • increase high and low min fee
  • fix security issue where one can stack up multiple msgs in same transaction and depending on the order of the msgs can benefits from a low fee, fixed by always using the max fee available

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #3429 (0db5b73) into master (0c63583) will increase coverage by 0.10%.
Report is 12 commits behind head on master.
The diff coverage is 40.23%.

❗ Current head 0db5b73 differs from pull request most recent head 1881d89. Consider uploading reports for the commit 1881d89 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3429      +/-   ##
==========================================
+ Coverage   43.35%   43.45%   +0.10%     
==========================================
  Files         166      175       +9     
  Lines       15895    16342     +447     
==========================================
+ Hits         6891     7102     +211     
- Misses       8591     8813     +222     
- Partials      413      427      +14     
Files Coverage Δ
app/app.go 94.08% <100.00%> (+3.97%) ⬆️
cmd/sifnoded/cmd/ibc-diag.go 15.74% <ø> (ø)
x/clp/types/codec.go 100.00% <100.00%> (ø)
x/clp/types/key_rewards_bucket.go 100.00% <100.00%> (ø)
x/clp/types/keys.go 84.21% <100.00%> (+0.87%) ⬆️
x/clp/types/querier.go 100.00% <ø> (ø)
x/dispensation/types/types.go 100.00% <100.00%> (ø)
x/ibctransfer/helpers/conversion_helper.go 37.19% <ø> (ø)
x/ibctransfer/keeper/msg_server.go 86.95% <ø> (ø)
app/setup_handlers.go 10.52% <0.00%> (+1.83%) ⬆️
... and 15 more

... and 2 files with indirect coverage changes

pgoos
pgoos previously approved these changes Nov 14, 2023
Copy link
Contributor

@pgoos pgoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

pgoos
pgoos previously approved these changes Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants