-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add chain-initiator tool to use mainnet snapshot in localnet #3435
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3435 +/- ##
==========================================
+ Coverage 43.35% 44.35% +1.00%
==========================================
Files 166 183 +17
Lines 15895 16736 +841
==========================================
+ Hits 6891 7423 +532
- Misses 8591 8868 +277
- Partials 413 445 +32
|
tokenregistrytypes.GenesisState | ||
|
||
Registry Registry `json:"registry"` | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't these types in the repo already? Sifgen is also encoding them, can that be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timlind I am using them here at line 117 but the problem is that for some structures they contain numbers that the JSON parser does not understand unless you replace the type of those fields by json.Number
and same goes for Duration type to string
. that’s why we rely on those extra definitions to override the types of those fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work 🚀
Here is how to run the
chain-initiator
tool:The command requires 3 arguments:
What it does?