Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update win_security_register_new_logon_process_by_rubeus.yml #5041

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

Koifman
Copy link
Contributor

@Koifman Koifman commented Oct 9, 2024

Summary of the Pull Request

adding "credential-access" since t1558 falls under it and was missing from the rule.

Changelog

chore: Register new Logon Process by Rubeus - add credential access att&ck tag

Example Log Event

N/A

Fixed Issues

N/A

SigmaHQ Rule Creation Conventions

  • If your PR adds new rules, please consider following and applying these conventions

adding "credential-access" since t1558 falls under it and was missing from the rule.
@github-actions github-actions bot added Rules Windows Pull request add/update windows related rules labels Oct 9, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @Koifman 👋

It looks like this is your first pull request on the Sigma rules repository!

Please make sure to read the SigmaHQ conventions document to make sure your contribution is adhering to best practices and has all the necessary elements in place for a successful approval.

Thanks again, and welcome to the Sigma community! 😃

@frack113
Copy link
Member

Hi,
the PR is for Rubeus but there is a "Suspicious Access to Browser Credential Files" rule.
Can you remove it ?
Thanks

@frack113 frack113 added the Author Input Required changes the require information from original author of the rules label Dec 14, 2024
@Koifman
Copy link
Contributor Author

Koifman commented Dec 14, 2024

Hi, the PR is for Rubeus but there is a "Suspicious Access to Browser Credential Files" rule. Can you remove it ? Thanks

Done @frack113

@frack113 frack113 removed the Author Input Required changes the require information from original author of the rules label Dec 14, 2024
@nasbench nasbench merged commit 3449958 into SigmaHQ:master Dec 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rules Windows Pull request add/update windows related rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants