[ATL] Assert on 'short circuiting' the list

If you try to append the list consisting of two or more elements to itself, you will end up in an infinite loop and leak memory.
SigmaTel71 · Sep 30, 2024 · 075ed9b · 075ed9b
1 parent 7be1e7d
commit 075ed9b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/sdk/lib/atl/atlcoll.h b/sdk/lib/atl/atlcoll.h
@@ -645,7 +645,7 @@ POSITION CAtlList<E, ETraits>::AddTail(INARGTYPE element)
 template <typename E, class ETraits>
 void CAtlList<E, ETraits>::AddHeadList(_In_ const CAtlList<E, ETraits>* plNew)
 {
-    ATLASSERT(plNew != NULL);
+    ATLASSERT(plNew != NULL && plNew != this);
 
     POSITION pos = plNew->GetTailPosition();
 
@@ -659,7 +659,7 @@ void CAtlList<E, ETraits>::AddHeadList(_In_ const CAtlList<E, ETraits>* plNew)
 template <typename E, class ETraits>
 void CAtlList<E, ETraits>::AddTailList(_In_ const CAtlList<E, ETraits>* plNew)
 {
-    ATLASSERT(plNew != NULL);
+    ATLASSERT(plNew != NULL && plNew != this);
 
     POSITION pos = plNew->GetHeadPosition();