Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): Fix logging incomplete information & LLM missing error #8128

Merged
merged 3 commits into from
Sep 21, 2024

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Sep 20, 2024

Background

We are still missing important log information & the llm failure doesn't propagate the error.

Changes πŸ—οΈ

Fix both issues.

Testing πŸ”

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@majdyz majdyz requested a review from ntindle September 20, 2024 23:44
@majdyz majdyz requested a review from a team as a code owner September 20, 2024 23:44
@majdyz majdyz requested review from Pwuts and removed request for a team September 20, 2024 23:44
@github-actions github-actions bot added the platform/backend AutoGPT Platform - Back end label Sep 20, 2024
Copy link

PR Reviewer Guide πŸ”

⏱️ Estimated effort to review: 2 πŸ”΅πŸ”΅βšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Key issues to review

Error Handling
The error handling has been changed from raising the output_data directly to raising a RuntimeError with output_data as the message. This might change the error type and structure that calling code expects.

Logging Format Change
The logging methods have been modified to include a prefix and extra information. This changes the log format and might affect log parsing or monitoring systems.

Copy link

netlify bot commented Sep 20, 2024

βœ… Deploy Preview for auto-gpt-docs canceled.

Name Link
πŸ”¨ Latest commit 2297b64
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/66eee24d1f920600083b47b3

@majdyz majdyz enabled auto-merge (squash) September 20, 2024 23:54
@majdyz majdyz requested a review from kcze September 21, 2024 15:09
@majdyz majdyz merged commit 52ee846 into master Sep 21, 2024
13 checks passed
@majdyz majdyz deleted the zamilmajdy/fix-logging-and-llm-error branch September 21, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: βœ… Done
Development

Successfully merging this pull request may close these issues.

2 participants