WIP: Full Library Integration PR #9407

Swiftyos · 2025-02-04T08:28:36Z

Changes 🏗️

Checklist 📋

For code changes:

I have clearly listed my changes in the PR description
I have made a test plan
I have tested my changes according to the test plan:
- ...

Example test plan

Create from scratch and execute an agent with at least 3 blocks
Import an agent from file upload, and confirm it executes correctly
Upload agent to marketplace
Import an agent from marketplace and confirm it executes correctly
Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

.env.example is updated or already compatible with my changes
docker-compose.yml is updated or already compatible with my changes
I have included a list of my configuration changes in the PR description (under Changes)

Examples of configuration changes

Changing ports
Adding new services that need to communicate with each other
Secrets or environment variable changes
New or infrastructure changes such as databases

…re-agents-without-agent-ownership

…without-agent-ownership' of github.com:Significant-Gravitas/AutoGPT into swiftyos/open-2276-add-ability-to-execute-store-agents-without-agent-ownership

…re-agents-without-agent-ownership

…ctionality

Co-authored-by: Reinier van der Leer <[email protected]>

…re-agents-without-agent-ownership

…without-agent-ownership' into swiftyos/open-2277-implement-library-add-update-remove-archive-functionality

…ctionality

…archive-functionality' into swiftyos/open-2278-implement-agent-preset-functionality

…lement-agent-preset-functionality

github-actions · 2025-02-05T22:09:46Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

…lement-new-agent-library-to-replace-monitor-page

github-actions · 2025-02-06T10:28:18Z

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

…lement-new-agent-library-to-replace-monitor-page

…ient

github-actions · 2025-02-10T13:45:04Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

ntindle · 2025-02-10T22:44:59Z

autogpt_platform/backend/backend/server/v2/library/routes/agents.py

+            detail=f"Store listing version {store_listing_version_id} not found",
+        ) from exc
+
+    except backend.server.v2.store.exceptions.DatabaseError as exc:


??? make a generic exceptions folder probs? why are we cross importing

ntindle · 2025-02-10T22:47:05Z

autogpt_platform/backend/backend/server/rest_api.py

+    @staticmethod
+    async def test_get_presets(user_id: str, page: int = 1, page_size: int = 10):
+        return await backend.server.v2.library.routes.presets.get_presets(
+            user_id=user_id, page=page, page_size=page_size
+        )


why are we mounting all of these here?

ntindle · 2025-02-10T22:48:12Z

autogpt_platform/backend/backend/server/routers/v1.py

@@ -309,11 +310,6 @@ async def get_graph(
    tags=["graphs"],
    dependencies=[Depends(auth_middleware)],
 )
-@v1_router.get(


if we're dropping the routers can we just delete the code?

ntindle · 2025-02-10T22:48:59Z

autogpt_platform/backend/backend/server/routers/v1.py

@@ -502,6 +523,7 @@ def execute_graph(
    graph_version: Optional[int] = None,
 ) -> dict[str, Any]:  # FIXME: add proper return type
    try:
+        logger.info("Node input: %s", node_input)


probs not needed and highly likely to leak personal data

ntindle · 2025-02-10T22:49:13Z

autogpt_platform/backend/backend/server/routers/v1.py

@@ -688,7 +669,7 @@ async def create_api_key(
        )
        return CreateAPIKeyResponse(api_key=api_key, plain_text_key=plain_text)
    except APIKeyError as e:
-        logger.error(f"Failed to create API key: {str(e)}")
+        logger.error("Failed to create API key: %s", e)


why all these changes?

ntindle · 2025-02-10T23:26:02Z

autogpt_platform/frontend/src/components/agptui/LibrarySearchBar.tsx

+    debouncedSearch(searchTerm);
+  };
+
+  return (


is this fundamentally different than the other search bar? why have two? can we push back on design to keep a subset of components and move faster

ntindle · 2025-02-10T23:28:05Z

autogpt_platform/frontend/src/components/agptui/LibraryUploadAgent.tsx

+  const updatedBlockIDMap: Record<string, string> = {
+    "a1b2c3d4-5e6f-7g8h-9i0j-k1l2m3n4o5p6":
+      "436c3984-57fd-4b85-8e9a-459b356883bd",
+    "b2g2c3d4-5e6f-7g8h-9i0j-k1l2m3n4o5p6":
+      "0e50422c-6dee-4145-83d6-3a5a392f65de",
+    "c3d4e5f6-7g8h-9i0j-1k2l-m3n4o5p6q7r8":
+      "a0a69be1-4528-491c-a85a-a4ab6873e3f0",
+    "c3d4e5f6-g7h8-i9j0-k1l2-m3n4o5p6q7r8":
+      "32a87eab-381e-4dd4-bdb8-4c47151be35a",
+    "b2c3d4e5-6f7g-8h9i-0j1k-l2m3n4o5p6q7":
+      "87840993-2053-44b7-8da4-187ad4ee518c",
+    "h1i2j3k4-5l6m-7n8o-9p0q-r1s2t3u4v5w6":
+      "d0822ab5-9f8a-44a3-8971-531dd0178b6b",
+    "d3f4g5h6-1i2j-3k4l-5m6n-7o8p9q0r1s2t":
+      "df06086a-d5ac-4abb-9996-2ad0acb2eff7",
+    "h5e7f8g9-1b2c-3d4e-5f6g-7h8i9j0k1l2m":
+      "f5b0f5d0-1862-4d61-94be-3ad0fa772760",
+    "a1234567-89ab-cdef-0123-456789abcdef":
+      "4335878a-394e-4e67-adf2-919877ff49ae",
+    "f8e7d6c5-b4a3-2c1d-0e9f-8g7h6i5j4k3l":
+      "f66a3543-28d3-4ab5-8945-9b336371e2ce",
+    "b29c1b50-5d0e-4d9f-8f9d-1b0e6fcbf0h2":
+      "716a67b3-6760-42e7-86dc-18645c6e00fc",
+    "31d1064e-7446-4693-o7d4-65e5ca9110d1":
+      "cc10ff7b-7753-4ff2-9af6-9399b1a7eddc",
+    "c6731acb-4105-4zp1-bc9b-03d0036h370g":
+      "5ebe6768-8e5d-41e3-9134-1c7bd89a8d52",
+  };


wtf is this? we gotta explain this with a comment or something and also should this be happening on the backend?

ntindle · 2025-02-10T23:28:41Z

autogpt_platform/frontend/src/components/agptui/composite/LibraryActionHeader.tsx

@@ -0,0 +1,35 @@
+"use client";


does this need to be a client compoentnet

ntindle · 2025-02-10T23:29:02Z

autogpt_platform/frontend/src/components/agptui/composite/LibraryActionSubHeader.tsx

@@ -0,0 +1,22 @@
+"use client";


does this need to be a client component

ntindle · 2025-02-10T23:30:46Z

autogpt_platform/frontend/src/lib/autogpt-server-api/client.ts

  }

  async addAgentToLibrary(storeListingVersionId: string): Promise<void> {
+    console.log("Adding to the library");


andrewhooker2

I've taken a look at only a few of the components to start here. I'd highly suggest taking a step back and keeping a few things in mind while working with these components.

Let's focus on having as little client components as possible. Think of our project as a tree where only the leaves should be client components. When building the pages and components we should continuously ask ourselves does our ui components we get from ShadcN already cover this and if so how can I use them.

One other thing to keep in mind is how React handles re-renders. A good bit of what is getting tracked with useState and other items I've seen here can simply be removed and handled by updating props. When React detects that the props flowing into the components have changed they will re-render.

andrewhooker2 · 2025-02-10T23:23:41Z

autogpt_platform/frontend/src/components/agptui/composite/LibraryActionHeader.tsx

@@ -0,0 +1,35 @@
+"use client";


The "use client" directive is being used here primarily because of the imported interactive components, but the main component structure is static layout.

The layout structure could be server-rendered, Only the individual interactive components (SearchBar, NotificationDropdown, UploadAgent) need to be client components

andrewhooker2 · 2025-02-10T23:43:42Z

autogpt_platform/frontend/src/app/agents/layout.tsx

This layout component is unnecessarily marked as a client component.
Layouts in Next.js should typically be server components unless there's a specific need for client-side interactivity.

andrewhooker2 · 2025-02-10T23:52:34Z

autogpt_platform/frontend/src/app/library/layout.tsx

@@ -0,0 +1,8 @@
+"use client";


This is another layout component is unnecessarily marked as a client component. Please understand that layout components should almost always be server. If you see a need for "use client" this is a key indicator of an anitpattern and should raise concerns for you.

andrewhooker2 · 2025-02-11T00:00:31Z

autogpt_platform/frontend/src/components/agptui/LibraryAgentCard.tsx

Good use of ShadcN Avatar component, but we could leverage more ShadcN components:

Consider using ShadcN Card component as the base instead of custom div

The hover effects could be standardized with ShadcN's hover utilities

The custom component here is labeled as a Card but you have yet to actually use a Card Component?

andrewhooker2 · 2025-02-11T00:02:32Z

autogpt_platform/frontend/src/components/agptui/LibraryAgentFilter.tsx

@@ -0,0 +1,63 @@
+import { LibraryAgentSortEnum } from "@/lib/autogpt-server-api";


The setTimeout in handleSortChange seems unnecessary - we should let React's natural state updates handle loading states

Id suggest checking into how React, and NextJS handle loading states.

andrewhooker2 · 2025-02-11T03:37:41Z

autogpt_platform/frontend/src/components/agptui/LibraryNotificationCard.tsx

For this component I'd suggest a bit of a refinement in your approach. Please keep these things in mind moving forward with your components.

Replace custom card with ShadCN Card components

Utilize ShadCN's built-in variants for different notification types

andrewhooker2 · 2025-02-11T03:46:54Z

autogpt_platform/frontend/src/components/agptui/LibraryNotificationDropdown.tsx

Looking at your Dropdown here it seems a bit overly complex. I think we could simplify this component quite a bit.

Let's focus on what the dropdown really needs:

A trigger button showing notification count

A dropdown menu

A list of notification items

Basic dismiss functionality

Start by removing the unnecessary features:

Remove Framer Motion animations

Remove custom scroll handling

Remove local state management for notifications

The initialNotificationData memo is unnecessary

Double state tracking for open isn't needed with ShadCN's DropdownMenu

Use ShadCN's built-in positioning and styling

Use Shad Cn Components:

DropdownMenu (already using)

Button with badge for notification count

ScrollArea for scrollable content

Toast for notifications instead of custom cards

Abhi1992002 and others added 30 commits December 27, 2024 10:02

small-changes

b44e6c5

draft-1

e321d17

Allow execution of store listings

4465994

Merge branch 'dev' into swiftyos/open-2276-add-ability-to-execute-sto…

6b9580b

…re-agents-without-agent-ownership

updated comment to make the meaning of userId clearer

6df94aa

Merge branch 'swiftyos/open-2276-add-ability-to-execute-store-agents-…

a7e0af0

…without-agent-ownership' of github.com:Significant-Gravitas/AutoGPT into swiftyos/open-2276-add-ability-to-execute-store-agents-without-agent-ownership

complete filters and searching

e249c90

add context provider for library agent page

74f79f6

Merge branch 'dev' into swiftyos/open-2276-add-ability-to-execute-sto…

c6daeef

…re-agents-without-agent-ownership

added preset functionality

69747cc

fixed merged error

4f861e3

fmt

797f9ed

Merge branch 'dev' into swiftyos/open-2278-implement-agent-preset-fun…

9750b79

…ctionality

Update autogpt_platform/backend/backend/server/model.py

c027080

Co-authored-by: Reinier van der Leer <[email protected]>

added error message to logs

46d573c

Update autogpt_platform/backend/backend/data/graph.py

bb8e562

Co-authored-by: Reinier van der Leer <[email protected]>

add from_db test

0c4888f

Merge branch 'dev' into swiftyos/open-2276-add-ability-to-execute-sto…

f051266

…re-agents-without-agent-ownership

complete upload functionality and fix filters

bfba440

add isActive filter back in

37e8b51

add preset execution

5259875

Merge branch 'swiftyos/open-2276-add-ability-to-execute-store-agents-…

783ca12

…without-agent-ownership' into swiftyos/open-2277-implement-library-add-update-remove-archive-functionality

add library management functions

37c5999

add db functions

fa5f24e

updated router

2a86f22

fix tests

bc8043b

Merge branch 'dev' into swiftyos/open-2278-implement-agent-preset-fun…

1f82ceb

…ctionality

Merge branch 'swiftyos/open-2277-implement-library-add-update-remove-…

6007def

…archive-functionality' into swiftyos/open-2278-implement-agent-preset-functionality

testing preset functionality

4d20e41

Merge remote-tracking branch 'origin/dev' into swiftyos/open-2278-imp…

d0c4a1f

…lement-agent-preset-functionality

Swiftyos added 4 commits February 4, 2025 11:55

update library agent route to have search, sort and pagination

c0a72ad

update library pages to match backend api

7ca8ad1

fix double defintion

e38d082

agents now saving and creating library agents

bc515fd

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Feb 5, 2025

Swiftyos added 2 commits February 6, 2025 11:25

Merge remote-tracking branch 'origin/dev' into swiftyos/open-2083-imp…

3af4498

…lement-new-agent-library-to-replace-monitor-page

updated yarn lock

15109ef

github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Feb 6, 2025

Swiftyos and others added 16 commits February 6, 2025 15:36

Merge remote-tracking branch 'origin/dev' into swiftyos/open-2083-imp…

a2cd454

…lement-new-agent-library-to-replace-monitor-page

fix get library agents

905b31c

updated backend for library page

382de80

use launch darkly

682e5a2

Merge remote-tracking branch 'origin/dev' into swiftyos/open-2083-imp…

7dfe30a

…lement-new-agent-library-to-replace-monitor-page

add runs page components

96f3348

cleaning up the backend code

57690b4

fix creator image url and description in library card

05a357c

fix initial loading of library agent

c94c3e1

remove scrolling aniamtion from header on library page

84b1c6f

remove scrolling aniamtion from header on library page

3b2ca4b

fix layout of library agent page

95cc190

fixing uploading mechanism ui/ux

75ed296

fix pagination

6ac082b

change backend routes to include sorting and filtering and updated cl…

ca772d8

…ient

follow design

45e17ad

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Feb 10, 2025

ntindle requested changes Feb 10, 2025

View reviewed changes

andrewhooker2 requested changes Feb 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Full Library Integration PR #9407

WIP: Full Library Integration PR #9407

Swiftyos commented Feb 4, 2025

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 10, 2025

ntindle Feb 10, 2025

ntindle Feb 10, 2025

ntindle Feb 10, 2025

ntindle Feb 10, 2025

ntindle Feb 10, 2025

ntindle Feb 10, 2025

ntindle Feb 10, 2025

ntindle Feb 10, 2025

ntindle Feb 10, 2025

ntindle Feb 10, 2025

andrewhooker2 left a comment

andrewhooker2 Feb 10, 2025

andrewhooker2 Feb 10, 2025

andrewhooker2 Feb 10, 2025

andrewhooker2 Feb 11, 2025

andrewhooker2 Feb 11, 2025

andrewhooker2 Feb 11, 2025

andrewhooker2 Feb 11, 2025

		@@ -0,0 +1,63 @@
		import { LibraryAgentSortEnum } from "@/lib/autogpt-server-api";

WIP: Full Library Integration PR #9407

Are you sure you want to change the base?

WIP: Full Library Integration PR #9407

Conversation

Swiftyos commented Feb 4, 2025

Changes 🏗️

Checklist 📋

For code changes:

For configuration changes:

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewhooker2 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment