Fixed shareus.io/shrs.link #34
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Diffusion123 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| "initial": "true", | ||
| "referrer": "https://shareus.io/", | ||
| } | ||
| DOMAIN = f"https://api.shrslink.xyz" |
There was a problem hiding this comment.
suggestion (code_refinement): Consider using a constant for the DOMAIN value.
Hardcoding URLs can lead to issues if the URL changes. It's better to define such URLs in a configuration file or as a constant at the top of the module.
| DOMAIN = f"https://api.shrslink.xyz" | |
| # At the top of the module | |
| API_DOMAIN = "https://api.shrslink.xyz" | |
| # In the relevant function or method | |
| DOMAIN = API_DOMAIN |
| if res: | ||
| return res.json()['link_info']['destination'] | ||
| else: | ||
| raise DDLException("Link Extraction Failed") |
There was a problem hiding this comment.
suggestion (code_clarification): Consider adding specific error messages for different failure cases.
Using the same error message for different types of failures can make debugging more difficult. Providing more specific messages can help identify issues more quickly.
| raise DDLException("Link Extraction Failed") | |
| raise DDLException("Link Extraction Failed: No response or invalid format received") |
| "initial": "true", | ||
| "referrer": "https://shareus.io/", | ||
| } | ||
| DOMAIN = f"https://api.shrslink.xyz" |
There was a problem hiding this comment.
issue (code-quality): We've found these issues:
- Use named expression to simplify assignment and conditional [×2] (
use-named-expression) - Replace f-string with no interpolated values with string (
remove-redundant-fstring)
Fixed Shareus.io / shrs.link