Skip to content

Commit

Permalink
reject join if meeting not generated or duplicate user
Browse files Browse the repository at this point in the history
  • Loading branch information
16BitNarwhal committed Aug 26, 2024
1 parent dea4905 commit 67328f7
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 15 deletions.
8 changes: 1 addition & 7 deletions api-server/chat.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,9 @@ def handle_join(data):
return
meeting_id = data['meeting_id']
username = data['username']
if meeting_id not in session_storage:
emit('error', 'Invalid meeting ID', room=meeting_id)
return
join_room(meeting_id)
session = session_storage[meeting_id]
if username in session_storage[meeting_id]['users']:
emit('error', 'User already joined', room=meeting_id)
return
session['users'].append(username)
join_room(meeting_id)
log_message('INFO', f'User {username} joined the meeting', meeting_id)
emit('user_joined', {'username': username, 'meeting_id': meeting_id}, room=meeting_id)

Expand Down
19 changes: 16 additions & 3 deletions client/src/pages/HomePage.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,24 @@ const HomePage = () => {
toast.error('Please enter a username before joining a meeting.');
return;
}
if (meetCode.trim()) {
navigate(`/meet/${meetCode}`, { state: { username } });
} else {
if (!meetCode.trim()) {
toast.error('Please enter a meeting code.');
return;
}

fetch(`${apiUrl}/api/session/${meetCode}`).then((response) => {
if (!response.ok) {
toast.error('Meeting code not found. Please try again.');
return;
}
return response.json();
}).then((data) => {
if (data.users.includes(username)) {
toast.error(`User ${username} is already in this meeting.`);
return;
}
navigate(`/meet/${meetCode}`, { state: { username } });
});
};

const handleCreateMeet = async () => {
Expand Down
5 changes: 0 additions & 5 deletions client/src/pages/MeetingPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,6 @@ const MeetingPage = () => {
setMessages((prevMessages) => [...prevMessages, msg]);
});

newSocket.on('error', (error) => {
toast.error(error);
navigate('/');
});

return () => newSocket.close();
}, [meeting_id, username, navigate]);

Expand Down

0 comments on commit 67328f7

Please sign in to comment.