Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:feat: Adds includeEdge flag in EventArrangers. #294

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

PRBaraiya
Copy link
Collaborator

@PRBaraiya PRBaraiya commented Nov 23, 2023

Description

This PR Adds the option to decide whether to include the edge while merging the overlapping events or not. It adds a new flag includeEdge in MergeEventArranger and SideEventArranger that will decide whether the events that overlaps on the edge should be merged or not. I've attached 2 image of SideEventArranger one with includeEdge true another with false.

includeEdge: true
includeEdge_Is_True

includeEdge: false
includeEdge_Is_False

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

This will fix the issue #290 .

@PRBaraiya PRBaraiya linked an issue Nov 23, 2023 that may be closed by this pull request
@PRBaraiya PRBaraiya force-pushed the feat/issue-290-add-flag-in-arrangers branch from 4803cfc to 87aed96 Compare November 23, 2023 12:16
@PRBaraiya PRBaraiya force-pushed the feat/issue-290-add-flag-in-arrangers branch from 87aed96 to 1f64061 Compare November 24, 2023 18:08
@ParthBaraiya ParthBaraiya self-requested a review December 13, 2023 10:29
@ParthBaraiya ParthBaraiya merged commit bfbb8aa into master Dec 13, 2023
1 check passed
@ParthBaraiya ParthBaraiya deleted the feat/issue-290-add-flag-in-arrangers branch December 13, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a way to stack events and not offset them ?
2 participants