Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Removes force unwrap while sorting the events. #295

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

PRBaraiya
Copy link
Collaborator

@PRBaraiya PRBaraiya commented Nov 23, 2023

Description

Removes the force unwrap on startTime in addEventInSortedManner method of MyList extension. This will fix the issue that was occurring while adding the events without startTime.

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Fixes issue #282 .

@PRBaraiya PRBaraiya linked an issue Nov 23, 2023 that may be closed by this pull request
@PRBaraiya PRBaraiya force-pushed the fix/issue-282 branch 2 times, most recently from 0186ab9 to 539cbbe Compare November 24, 2023 18:05
@ParthBaraiya ParthBaraiya merged commit 060fb36 into master Dec 13, 2023
1 check passed
@ParthBaraiya ParthBaraiya deleted the fix/issue-282 branch December 13, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null check exception when adding multiple events without startTime
2 participants