Issue 311 start hour #319
Merged
Issue 311 start hour #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to handle how events are placed in the calendar, components modified : - WeekView - DayView - InternalDayView - InternalWeekView - TimeLine - HourLinePainter - HalfHourLinePainter - PressDetector
Modifications on EventArrangers so they are placing events in function of 'startHour' argument. Widgets Modified : - EventArrangers - MergeEventArrangers - SideEventArrangers + Modifications on DayView, so we can pass it the 'startHour' argument
This was referenced Feb 3, 2024
|
can anyone review and merge this PR please? |
|
Thanks for creating this PR @rmpt . If possible can you please resolve the conflict in one file. I will review this immediately. |
|
@ParthBaraiya please give it a look |
|
@rmpt A good and needed feature thank you 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forked from issue 240 that has been dead from some time.
This feature adds a startHour parameter in WeekView + DayView that allows us to choose from which hour a day will be displayed. The parameter is an int that goes from 0 to 23.
Example with the startHour parameter set to 5 :
Checklist
The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
I have followed the Contributor Guide when preparing my PR.
I have updated/added tests for ALL new/updated/fixed functionality.
I have updated/added relevant documentation in docs and added dartdoc comments with ///.
Breaking Change?
Yes, this PR is a breaking change.
Related Issues
Based on the issue #240 but only resolves the 'min' hour.