Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛onDateTap triggered issue resolved by changing customPaint height #332. #335

Conversation

ravilsimform
Copy link
Contributor

  • The size of the LiveTimeLine's painting area is now determined by the screen size that I've adjusted, and it has been replaced by LiveTimeIndicatorSettings.height.

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

#332

SimformSolutionsPvtLtd#332.

- The size of the LiveTimeLine's painting area is now determined by the screen size that I've adjusted, and it has been replaced by LiveTimeIndicatorSettings.height.
@humanolaranja
Copy link

Perfect. Can someone review and release a new version? This is a very important fix
@jaiminrana05 @ParthBaraiya @vatsaltanna-simformsolutions @tejas-ardeshna @BirjuVachhani @DevarshRanpara

Copy link
Collaborator

@ParthBaraiya ParthBaraiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ParthBaraiya ParthBaraiya merged commit e310366 into SimformSolutionsPvtLtd:master Mar 24, 2024
1 check passed
@humanolaranja
Copy link

@ParthBaraiya do you have any information when we'll have a new release with this fix?

@humanolaranja
Copy link

Updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants