Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add check to keep hour in timeline (in day and week view) if LiveTimeIndicator time or bubble dosen't overlap. #343

Conversation

mataai
Copy link
Contributor

@mataai mataai commented Apr 12, 2024

Description

Fixes: #336

Updates the visibility check on the timeline hour to keep it displayed if both showTime and showTimeBackgroundView on the LiveTimeIndicator are not enabled.
Currently if both showTime and showTimeBackgroundView display are both disabled the hours next to the current time disappears 15 minutes before and after to prevent overlap.
With this change the hour in the timeline will disappear only if both showTime and showTimeBackgroundView are enabled in the liveTimeIndicatorSettings.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #336

@mataai mataai changed the title fix: add check to keep hour in timeline in day and week if LiveTimeIndicator time or bubble dosen't overlap. fix: add check to keep hour in timeline (in day and week view) if LiveTimeIndicator time or bubble dosen't overlap. Apr 12, 2024
Copy link

@Vinnie1991 Vinnie1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've the bug also in one of mine applications. And when I've used this commit the issue resolves.

@vatsaltanna-simformsolutions vatsaltanna-simformsolutions merged commit 3ed5bf6 into SimformSolutionsPvtLtd:master May 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

current time not shown in timeline
4 participants