fix: 🐛 onDateTap return wrong date when startHour is set #341 #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/src/day_view/day_view.dart
Outdated
| @@ -634,7 +634,7 @@ class DayViewState<T extends Object?> extends State<DayView<T>> { | |||
| date.month, | |||
| date.day, | |||
| 0, | |||
| minuteSlotSize.minutes * i, | |||
| minuteSlotSize.minutes * i + (_startHour * 60), | |||
There was a problem hiding this comment.
This appears to be a duplicate widget in both the day view and the week view. Could you please create a separate, common widget for this?
- add startHour minutes (startHour * 60) to DateTime which then passed as arguments to onDateTap
apurva010
force-pushed
the
fix/issue_341_onDateTap_changes
branch
from
bafbdb0 to
c782b36
Compare
|
Close this and create a new one : #350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #341