Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Provide more configurations for page headers. #408

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

ParthBaraiya
Copy link
Collaborator

@ParthBaraiya ParthBaraiya commented Sep 18, 2024

Description

  • Adds additional configurations for HeaderStyle.
    • Added mainAxisSize, mainAxisAlignment, rightIconConfig and leftIconConfig.
  • Adds additional configurations for CalendarPageHeader, MonthPageHeader, DayPageHeader and WeekPageHeader.
    • Added titleBuilder to build custom title for header.
  • Deprecations:
    • deprecated backgroundColor and iconColor from CalendarPageHeader, DayPageHeader, MonthPageHeader and WeekPageHeader.
      • Solution: use headerStyle instead.
    • deprecated leftIconVisible, rightIconVisible, leftIconPadding, rightIconPadding, leftIcon and rightIcon from HeaderStyle.
      • Solution: use rightIconConfig and leftIconConfig instead.

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Though this PR does not have any breaking changes, it has many deprecations which will be removed in next major release. So, resolve all the deprecation ASAP.

You can follow migration guide for help.

Related Issues

None

@ParthBaraiya ParthBaraiya force-pushed the feature/add-more-configurations-in-header-style branch from 9e84896 to e730cba Compare September 18, 2024 18:00
Copy link
Collaborator

@PRBaraiya PRBaraiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PRBaraiya PRBaraiya merged commit 982747f into master Oct 22, 2024
1 check passed
@PRBaraiya PRBaraiya deleted the feature/add-more-configurations-in-header-style branch October 22, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants