Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fixes issue #385: Add showWeekends flag in month view #422

Merged
merged 1 commit into from
Dec 20, 2024
Merged

feat: Fixes issue #385: Add showWeekends flag in month view #422

merged 1 commit into from
Dec 20, 2024

Conversation

shubham-jitiya-simform
Copy link
Contributor

@shubham-jitiya-simform shubham-jitiya-simform commented Dec 3, 2024 •
edited
Loading

Description

  • Fixed if daysNotInMonth true hide events on hidden date.
  • Added showWeekends flag to hide weekends. Default value is true.
  • Removed empty rows if entire week dates doesn't fall in current month.
  • Updated readme & change log
  • Attached GIF which shows example.
ShowWeekends flag

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closses #385

@shubham-jitiya-simform shubham-jitiya-simform force-pushed the feature/month_view_show_weekends_flag branch from 533ac77 to f02a3aa Compare December 3, 2024 11:04
@shubham-jitiya-simform shubham-jitiya-simform changed the title feature/month_view_show_weekends_flag feat: Fixes issue #385: Add showWeekends flag in month view Dec 3, 2024
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the feature/month_view_show_weekends_flag branch 5 times, most recently from 4c8ddf1 to c8405fb Compare December 3, 2024 16:49
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the feature/month_view_show_weekends_flag branch 4 times, most recently from d405057 to fe79f47 Compare December 4, 2024 10:07
@shubham-jitiya-simform shubham-jitiya-simform marked this pull request as ready for review December 4, 2024 10:21
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the feature/month_view_show_weekends_flag branch from fe79f47 to c89a7b2 Compare December 4, 2024 10:28
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the feature/month_view_show_weekends_flag branch from 37df9f1 to e98b9e7 Compare December 16, 2024 06:18
ParthBaraiya
ParthBaraiya requested changes Dec 17, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
lib/src/extensions.dart Outdated Show resolved Hide resolved
lib/src/month_view/month_view.dart Outdated Show resolved Hide resolved
lib/src/month_view/month_view.dart Outdated Show resolved Hide resolved
lib/src/month_view/month_view.dart Outdated Show resolved Hide resolved
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the feature/month_view_show_weekends_flag branch from e98b9e7 to 06e092e Compare December 18, 2024 14:00
ParthBaraiya
ParthBaraiya requested changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@ParthBaraiya ParthBaraiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use where instead of take. take will cause issue if startDay if other than monday.

@shubham-jitiya-simform shubham-jitiya-simform force-pushed the feature/month_view_show_weekends_flag branch 2 times, most recently from 198f9ca to 46cfb84 Compare December 19, 2024 13:12
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the feature/month_view_show_weekends_flag branch from 46cfb84 to d13fa9a Compare December 19, 2024 13:13
PRBaraiya
PRBaraiya approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@PRBaraiya PRBaraiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ParthBaraiya ParthBaraiya merged commit 095ede2 into master Dec 20, 2024
1 check failed
@ParthBaraiya ParthBaraiya deleted the feature/month_view_show_weekends_flag branch December 20, 2024 05:26
@ParthBaraiya
Copy link
Collaborator

RIght now, the github action is giving error which should be fixed in dark theme support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PRBaraiya PRBaraiya PRBaraiya approved these changes

@ParthBaraiya ParthBaraiya ParthBaraiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubham-jitiya-simform @ParthBaraiya @PRBaraiya