Skip to content

Commit

Permalink
Mirror: Fix air not existing in corner window tiles (#123)
Browse files Browse the repository at this point in the history
## Mirror of PR #25926: [Fix air not existing in corner window
tiles](space-wizards/space-station-14#25926)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `24fd1a93ff59ca8d6091ca15205c776ec2144146`

PR opened by <img
src="https://avatars.githubusercontent.com/u/20659419?v=4"
width="16"/><a href="https://github.com/MACMAN2003"> MACMAN2003</a> at
2024-03-08 05:40:47 UTC
PR merged by <img
src="https://avatars.githubusercontent.com/u/19864447?v=4"
width="16"/><a href="https://github.com/web-flow"> web-flow</a> at
2024-03-08 07:50:34 UTC

---

PR changed 10 files with 50 additions and 0 deletions.

The PR had the following labels:
- No C#


---

<details open="true"><summary><h1>Original Body</h1></summary>

> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
> 
> ## About the PR
> <!-- What did you change in this PR? -->
> the corner walls are untouched because they didn't have this issue
(they actually held the solution)
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> fixes space-wizards/space-station-14#25924
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
> 
> ## Media
> <!-- 
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
> 
> If you're unsure whether your PR will require media, ask a maintainer.
> 
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
> 
> - [x] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
> 
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
> 
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
> 
> <!--
> Make sure to take this Changelog template out of the comment block in
order for it to show up.
> 🆑
> - add: Added fun!
> - remove: Removed fun!
> - tweak: Changed fun!
> - fix: Fixed fun!
> -->
> 🆑
> - fix: Diagonal windows no longer space you when in a pressurized
environment.


</details>

Co-authored-by: MACMAN2003 <[email protected]>
  • Loading branch information
SimpleStation14 and MACMAN2003 authored May 4, 2024
1 parent e97c0a9 commit 6862d33
Show file tree
Hide file tree
Showing 10 changed files with 50 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,11 @@
- FullTileMask
layer:
- GlassLayer
- type: Airtight
noAirWhenFullyAirBlocked: false
airBlockedDirection:
- South
- East
- type: DamageVisuals
damageOverlay:
sprite: Structures/Windows/cracks_diagonal.rsi
Expand Down
5 changes: 5 additions & 0 deletions Resources/Prototypes/Entities/Structures/Windows/mining.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@
- FullTileMask
layer:
- GlassLayer
- type: Airtight
noAirWhenFullyAirBlocked: false
airBlockedDirection:
- South
- East
- type: DamageVisuals
damageOverlay:
sprite: Structures/Windows/cracks_diagonal.rsi
5 changes: 5 additions & 0 deletions Resources/Prototypes/Entities/Structures/Windows/plasma.yml
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,11 @@
- FullTileMask
layer:
- GlassLayer
- type: Airtight
noAirWhenFullyAirBlocked: false
airBlockedDirection:
- South
- East
- type: DamageVisuals
damageOverlay:
sprite: Structures/Windows/cracks_diagonal.rsi
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@
- FullTileMask
layer:
- GlassLayer
- type: Airtight
noAirWhenFullyAirBlocked: false
airBlockedDirection:
- South
- East
- type: DamageVisuals
damageOverlay:
sprite: Structures/Windows/cracks_diagonal.rsi
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,11 @@
- FullTileMask
layer:
- GlassLayer
- type: Airtight
noAirWhenFullyAirBlocked: false
airBlockedDirection:
- South
- East
- type: DamageVisuals
damageOverlay:
sprite: Structures/Windows/cracks_diagonal.rsi
Expand Down
5 changes: 5 additions & 0 deletions Resources/Prototypes/Entities/Structures/Windows/rplasma.yml
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,11 @@
- FullTileMask
layer:
- GlassLayer
- type: Airtight
noAirWhenFullyAirBlocked: false
airBlockedDirection:
- South
- East
- type: DamageVisuals
damageOverlay:
sprite: Structures/Windows/cracks_diagonal.rsi
Expand Down
5 changes: 5 additions & 0 deletions Resources/Prototypes/Entities/Structures/Windows/ruranium.yml
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,11 @@
- FullTileMask
layer:
- GlassLayer
- type: Airtight
noAirWhenFullyAirBlocked: false
airBlockedDirection:
- South
- East
- type: DamageVisuals
damageOverlay:
sprite: Structures/Windows/cracks_diagonal.rsi
Expand Down
5 changes: 5 additions & 0 deletions Resources/Prototypes/Entities/Structures/Windows/shuttle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@
- FullTileMask
layer:
- GlassLayer
- type: Airtight
noAirWhenFullyAirBlocked: false
airBlockedDirection:
- South
- East
- type: DamageVisuals
damageOverlay:
sprite: Structures/Windows/cracks_diagonal.rsi
5 changes: 5 additions & 0 deletions Resources/Prototypes/Entities/Structures/Windows/uranium.yml
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,11 @@
- FullTileMask
layer:
- GlassLayer
- type: Airtight
noAirWhenFullyAirBlocked: false
airBlockedDirection:
- South
- East
- type: DamageVisuals
damageOverlay:
sprite: Structures/Windows/cracks_diagonal.rsi
Expand Down
5 changes: 5 additions & 0 deletions Resources/Prototypes/Entities/Structures/Windows/window.yml
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,11 @@
- FullTileMask
layer:
- GlassLayer
- type: Airtight
noAirWhenFullyAirBlocked: false
airBlockedDirection:
- South
- East
- type: DamageVisuals
damageOverlay:
sprite: Structures/Windows/cracks_diagonal.rsi
Expand Down

0 comments on commit 6862d33

Please sign in to comment.