Skip to content

Commit

Permalink
Mirror: Wearable Harmonicas (#386)
Browse files Browse the repository at this point in the history
## Mirror of PR #26261: [Wearable
Harmonicas](space-wizards/space-station-14#26261)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `b60f61c7b79cebf07743c057e4a89202ca06f258`

PR opened by <img
src="https://avatars.githubusercontent.com/u/59857479?v=4"
width="16"/><a href="https://github.com/ImWeax"> ImWeax</a> at
2024-03-19 14:18:13 UTC

---

PR changed 1 files with 7 additions and 1 deletions.

The PR had the following labels:
- No C#
- Status: Needs Review


---

<details open="true"><summary><h1>Original Body</h1></summary>

> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
> 
> ## About the PR
> <!-- What did you change in this PR? -->
> Made harmonicas wearable (and playable) in the neck slot.
> 
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> Sprite has a neck loop and it was bugging me you couldn't wear them
> 
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
> 
> ## Media
> <!-- 
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
> 
> If you're unsure whether your PR will require media, ask a maintainer.
> 
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
> 
> - [x] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
> 
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
> 
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
> 
> <!--
> Make sure to take this Changelog template out of the comment block in
order for it to show up.
> -->
> 🆑 Weax
> - tweak: Harmonicas can now be equipped (and played) in the neck slot.
> 
> 


</details>

Co-authored-by: SimpleStation14 <Unknown>
  • Loading branch information
SimpleStation14 committed May 3, 2024
1 parent ebf4280 commit 69408b1
Showing 1 changed file with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
- KeyedInstrument

- type: entity
parent: BaseHandheldInstrument
parent: [BaseHandheldInstrument, Clothing]
id: HarmonicaInstrument
name: harmonica
components:
Expand All @@ -64,6 +64,13 @@
- type: Item
size: Small
sprite: Objects/Fun/Instruments/harmonica.rsi
storedRotation: -90
- type: Clothing
quickEquip: false
slots:
- neck
- type: ActivatableUI
inHandsOnly: false
- type: Tag
tags:
- WoodwindInstrument
Expand Down

0 comments on commit 69408b1

Please sign in to comment.