Skip to content

Commit

Permalink
Mirror: Democratize C-20r SMG Magazines (#199)
Browse files Browse the repository at this point in the history
## Mirror of PR #26086: [Democratize C-20r SMG
Magazines](space-wizards/space-station-14#26086)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `c07213c2473453179f525956ff16631a5b77c9cc`

PR opened by <img
src="https://avatars.githubusercontent.com/u/68826635?v=4"
width="16"/><a href="https://github.com/Ghagliiarghii">
Ghagliiarghii</a> at 2024-03-13 18:08:33 UTC

---

PR changed 1 files with 0 additions and 5 deletions.

The PR had the following labels:
- No C#


---

<details open="true"><summary><h1>Original Body</h1></summary>

> Previously the C-20r magazines were only available for nukies to
purchase, but regular syndicate agents could purchase the actual C-20r
bundle to get the gun and some magazines. This strikes me an
inconsistent.
> 
> This would be a very minor / QoL buff to normal syndicate agents, as
before they could purchase three instances of the .35 auto pistol
magazines (for the Viper) and manually load all that ammo into an empty
C-20r magazine. This is less annoying to do but would cost 2 TC instead
of the 3 TC from the 3 1 TC cost Viper magazines; potentially allowing
an agent to have one additional TC for this specific circumstance. It
should be noted that this still costs 19 TC (as opposed to the previous
20) so it still doesn't leave a lot of room for other purchases
normally.
> 
> I think a 1 TC savings from buying one thing instead of 3 is a
reasonable bundle discount.
> 
> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
> 
> ## About the PR
> <!-- What did you change in this PR? -->
> It doesn't make sense to me that a normal syndicate agent is allowed
access to the C-20r magazines through a bundle they can purchase but not
access to the magazines by themselves. Additionally it doesn't strike me
as a big power difference so I see no reason why they shouldn't be able
to purchase these balance wise.
> 
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> This is a slight QoL buff to syndicate agents, it would, at worst,
allow an agent one additional TC of purchasing power and a slightly
faster reload to a gun that already cost almost all their TC.
> 
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
> Removed whitelist flag for NukeOps for the C-20r magazine in the
uplink.
> 
> ## Media
> <!-- 
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
> 
> If you're unsure whether your PR will require media, ask a maintainer.
> 
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
> 
> - [ ] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
> 
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
> 
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
> 
> <!--
> Make sure to take this Changelog template out of the comment block in
order for it to show up.
> 🆑
> - add: Added fun!
> - remove: Removed fun!
> - tweak: Changed fun!
> - fix: Fixed fun!
> -->
> 


</details>

Co-authored-by: SimpleStation14 <Unknown>
  • Loading branch information
SimpleStation14 authored May 5, 2024
1 parent a751152 commit dfe649c
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions Resources/Prototypes/Catalog/uplink_catalog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -308,11 +308,6 @@
Telecrystal: 2
categories:
- UplinkAmmo
conditions:
- !type:StoreWhitelistCondition
whitelist:
tags:
- NukeOpsUplink

# For the Cobra
- type: listing
Expand Down

0 comments on commit dfe649c

Please sign in to comment.