Make Dionas Slow And Steady (#704)

# Description

Dionas now have 25% slower movement speed in exchange for total slip
immunity and slow immunity (except lying down).

Note that this also prevents slowdowns from hunger and thirst.

This also fixes an existing bug with Sluggish and Snail-Paced related to
`TraitSpeedModifierSystem`, as it was not applying the reduced movement
speed upon spawning, only when the movement speed has been modified by
another source. `TraitSpeedModifierSystem` has been moved from
`Content.Server` to `Content.Shared`.

This used to be a trait costing 3 points, but is now given for free to
all Dionas per request of @VMSolidus.

## Media

<details><summary>Expand</summary>

**Speed with no items**


![image](https://github.com/user-attachments/assets/b723614a-79fe-401c-ae53-2ad98ff9a6d3)

**Speed wearing a jugsuit, wearing a duffel bag, holding one duffel bag
in each arm, and walking through a puddle of glue covered in spider
webs.**


![image](https://github.com/user-attachments/assets/a934d2c1-437f-463c-8fe3-63b7b54a1f58)

</details>

# Changelog

:cl: Skubman
- add: Dionas have been given a 25% slower movement speed. In exchange
for that, they gain absolute slip immunity and movement speed modifier
immunity. This makes them immune to slowdown from things like
duffelbags, hardsuits, and spider webs.
- fix: Sluggish and Snail-Paced will now properly apply their movement
penalties upon joining.

Content.Server/Standing/LayingDownSystem.cs

@@ -48,7 +48,7 @@ private void OnRefreshMovementSpeed(EntityUid uid, LayingDownComponent component
         if (TryComp<StandingStateComponent>(uid, out var standingState) && standingState.Standing)
             return;
 
-        args.ModifySpeed(component.DownedSpeedMultiplier, component.DownedSpeedMultiplier);
+        args.ModifySpeed(component.DownedSpeedMultiplier, component.DownedSpeedMultiplier, bypassImmunity: true);
     }
 
     private void OnParentChanged(EntityUid uid, LayingDownComponent component, EntParentChangedMessage args)

Content.Shared/Movement/Systems/MovementSpeedModifierSystem.cs

@@ -1,5 +1,6 @@
 using Content.Shared.Inventory;
 using Content.Shared.Movement.Components;
+using Content.Shared.Traits.Assorted.Components;
 using Robust.Shared.Timing;
 
 namespace Content.Shared.Movement.Systems
@@ -16,7 +17,11 @@ public void RefreshMovementSpeedModifiers(EntityUid uid, MovementSpeedModifierCo
             if (_timing.ApplyingState)
                 return;
 
-            var ev = new RefreshMovementSpeedModifiersEvent();
+            var isImmune = false;
+            if (HasComp<SpeedModifierImmunityComponent>(uid))
+                isImmune = true;
+
+            var ev = new RefreshMovementSpeedModifiersEvent(isImmune);
             RaiseLocalEvent(uid, ev);
 
             if (MathHelper.CloseTo(ev.WalkSpeedModifier, move.WalkSpeedModifier) &&
@@ -64,10 +69,24 @@ public sealed class RefreshMovementSpeedModifiersEvent : EntityEventArgs, IInven
         public float WalkSpeedModifier { get; private set; } = 1.0f;
         public float SprintSpeedModifier { get; private set; } = 1.0f;
 
-        public void ModifySpeed(float walk, float sprint)
+        /// <summary>
+        ///    Whether this entity is immune to most movement speed modifiers.
+        ///    Bypassable by setting bypassImmunity to true.
+        /// </summary
+        private bool IsImmune = false;
+
+        public void ModifySpeed(float walk, float sprint, bool bypassImmunity = false)
         {
+            if (IsImmune && !bypassImmunity)
+                return;
+
             WalkSpeedModifier *= walk;
             SprintSpeedModifier *= sprint;
         }
+
+        public RefreshMovementSpeedModifiersEvent(bool isImmune = false)
+        {
+            IsImmune = isImmune;
+        }
     }
 }

Content.Shared/Traits/Assorted/Components/SpeedModifierImmunityComponent.cs

@@ -0,0 +1,12 @@
+using Robust.Shared.GameStates;
+
+namespace Content.Shared.Traits.Assorted.Components;
+
+/// <summary>
+///   This is used to make an entity's movement speed constant and
+///   never affected by almost all movement speed modifiers.
+/// </summary>
+[RegisterComponent, NetworkedComponent]
+public sealed partial class SpeedModifierImmunityComponent : Component
+{
+}

Content.Server/Traits/Assorted/TraitSpeedModifierComponent.cs → Content.Shared/Traits/Assorted/Components/TraitSpeedModifierComponent.cs

@@ -1,14 +1,16 @@
-namespace Content.Server.Traits.Assorted;
+using Robust.Shared.GameStates;
+
+namespace Content.Shared.Traits.Assorted.Components;
 
 /// <summary>
 ///  This component is used for traits that modify movement speed.
 /// </summary>
-[RegisterComponent]
+[RegisterComponent, NetworkedComponent, AutoGenerateComponentState]
 public sealed partial class TraitSpeedModifierComponent : Component
 {
-    [DataField(required: true)]
+    [DataField, AutoNetworkedField]
     public float WalkModifier = 1.0f;
 
-    [DataField(required: true)]
+    [DataField, AutoNetworkedField]
     public float SprintModifier = 1.0f;
 }

Content.Shared/Traits/Assorted/Systems/TraitSpeedModifierSystem.cs

@@ -0,0 +1,31 @@
+using Content.Shared.Movement.Components;
+using Content.Shared.Movement.Systems;
+using Content.Shared.Traits.Assorted.Components;
+
+namespace Content.Shared.Traits.Assorted.Systems;
+
+public sealed class TraitSpeedModifierSystem : EntitySystem
+{
+    [Dependency] private readonly MovementSpeedModifierSystem _movement = default!;
+
+    public override void Initialize()
+    {
+        base.Initialize();
+
+        SubscribeLocalEvent<TraitSpeedModifierComponent, ComponentStartup>(OnStartup);
+        SubscribeLocalEvent<TraitSpeedModifierComponent, RefreshMovementSpeedModifiersEvent>(OnRefreshMovementSpeed);
+    }
+
+    private void OnRefreshMovementSpeed(EntityUid uid, TraitSpeedModifierComponent component, RefreshMovementSpeedModifiersEvent args)
+    {
+        args.ModifySpeed(component.WalkModifier, component.SprintModifier, bypassImmunity: true);
+    }
+
+    private void OnStartup(EntityUid uid, TraitSpeedModifierComponent component, ComponentStartup args)
+    {
+        if (!TryComp<MovementSpeedModifierComponent>(uid, out var move))
+            return;
+
+        _movement.RefreshMovementSpeedModifiers(uid, move);
+    }
+}

Resources/Prototypes/Entities/Mobs/Species/diona.yml

@@ -109,6 +109,11 @@
     understands:
     - GalacticCommon
     - RootSpeak
+  - type: TraitSpeedModifier
+    sprintModifier: 0.75
+    walkModifier: 0.75
+  - type: SpeedModifierImmunity
+  - type: NoSlip
 
 - type: entity
   parent: BaseSpeciesDummy

Resources/Prototypes/Traits/disabilities.yml

@@ -105,6 +105,10 @@
       traits:
         - ParkourTraining
         - SnailPaced
+    - !type:CharacterSpeciesRequirement
+      inverted: true
+      species:
+        - Diona
   components:
     - type: TraitSpeedModifier
       sprintModifier: 0.85
@@ -124,6 +128,10 @@
       traits:
         - ParkourTraining
         - Sluggish
+    - !type:CharacterSpeciesRequirement
+      inverted: true
+      species:
+        - Diona
   components:
     - type: TraitSpeedModifier
       sprintModifier: 0.7

Resources/Prototypes/Traits/skills.yml

@@ -97,6 +97,10 @@
       traits:
         - Sluggish
         - SnailPaced
+    - !type:CharacterSpeciesRequirement
+      inverted: true
+      species:
+        - Diona
   components:
     - type: ClimbDelayModifier
       climbDelayMultiplier: 0.70