9 More Traits (#918)

# Description

This "ZERO C#" Pr adds 10 additional traits to the game, which only make
use of pre-existing components, along with some of the new TraitSystem
functionality. These are the following new traits:

- **Photophobia**: Functions as per Vulpkanin Light Sensitivity
- **Clumsy**: Functions as per Clown clumsiness
- **Small**: Functions as per Felinid PseudoItem, requires a character
be Felinid sized
- **Temperature Tolerance**: Functions as per Vulpkanin low temperature
resistance
- **Spinarette**: Functions as per the same ability from Arachnids.
- **Talons**: Replaces your melee natural attacks with Piercing talons
- **Claws**: Replaces your melee natural attacks with Slashing claws
- **Striking Calluses**: [Human only, requires Martial Artist or Boxer
job], increases your base unarmed attack to 6 damage, from 5.
- **Natural Weapon Removal**: For species with melee attacks other than
blunt, replaces Talons or Claws with Fist.

## TODO:

- [ ] Adjust the points costs/additions for these traits to ensure
balance. Although I can't imagine most of them being changed. I do still
wish for a decent number of traits to be within the 1 to 3 point range.

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>


![image](https://github.com/user-attachments/assets/c2e7a42b-2b1f-43ea-8f0d-5275c06c51ae)


![image](https://github.com/user-attachments/assets/bb60ffbe-0755-483b-b3a4-028764b465a7)

</p>
</details>

# Changelog

:cl:
- add: 10 new Traits have been added to the game. Photophobia, Clumsy,
Small, Temperature Tolerance, Claws, Talons, Natural Weapon Removal,
Striking Calluses, and Spinarette.

---------

Signed-off-by: VMSolidus <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>

Resources/Locale/en-US/traits/traits.ftl

@@ -228,6 +228,68 @@ trait-description-AnomalousPositronics =
     your positronic brain lacks its standard psionic insulation. As a being that can be argued to have a soul,
     this by extension means that it is possible for you to be influenced by the Noosphere.
 
+trait-name-Photophobia = Photophobia
+trait-description-Photophobia =
+    Your eyes are extremely sensitive to bright lights.
+    As a result, you may be blinded for a greater duration than others when exposed to sudden flashes of light.
+    Your eyes are also more likely to be injured by flashes.
+
+trait-name-Clumsy = Clumsy
+trait-description-Clumsy =
+    You have a severe deficiency in hand-eye-coordination, resulting in an inability to do some things that others would take for granted.
+    Any weapons you may try to use are more likely to injure yourself than others. You are unable to climb any objects without injuring yourself.
+
+trait-name-Small = Small
+trait-description-Small =
+    You are much smaller than a typical person, and can climb into spaces others would not normally be able to fit into, such as duffel bags.
+    This trait does not in any way modify your character's size, it merely requires that your character be at most the size of a standard Felinid.
+
+trait-name-TemperatureTolerance = Temperature Tolerance
+trait-description-TemperatureTolerance =
+    You have a notable tolerance for lower temperatures. You can stand for extended periods of time
+    in conditions just slightly below freezing, such as the inside of a kitchen fridge,
+    or the sunlit mountainside of the famous Glacier station.
+
+trait-name-Talons = Talons
+trait-description-Talons =
+    Your fingertips have been replaced with piercing talons.
+    These could come from gene modifications, vatgrown implants,
+    or even hard plastic retractable talons incorpoated into a prosthetic limb.
+    Your unarmed melee attacks deal Piercing damage instead of the standard damage type for your species.
+    This has no effect on damage dealt with any form of armed melee.
+
+trait-name-Claws = Claws
+trait-description-Claws =
+    Your fingertips have been replaced with sharp claws.
+    These could come from gene modifications, vatgrown implants,
+    or even hard plastic retractable claws incorpoated into a prosthetic limb.
+    Your unarmed melee attacks deal Slashing damage instead of the standard damage type for your species.
+    This has no effect on damage dealt with any form of armed melee.
+
+trait-name-NaturalWeaponRemoval = Natural Weapons Removal
+trait-description-NaturalWeaponRemoval =
+    Whatever "Natural Weapons" your species are normally born with have been surgically removed.
+    This could have been done to better fit in with terran space stations, or as a cosmetic choice.
+    As a result, your unarmed attacks deal Blunt damage instead of the standard damage type for your species.
+    This has no effect on damage dealt with any form of armed melee.
+
+trait-name-StrikingCalluses = Striking Calluses
+trait-description-StrikingCalluses =
+    An iconic enhancement commonly found in the world of cyberenhanced martial arts.
+    Striking Calluses consist of bony dermal deposits grafted into a user's hands, either inside the palm
+    for "Tiger Style" fighting, or just below the knuckles for those who favor traditional boxing.
+    Owners of prosthetic or bionic limbs would instead have a hard plastic shell over their knuckles.
+    These enhancements increase your unarmed strike damage by 1 point base, but do not confer
+    any benefits to any form of armed melee.
+
+trait-name-Spinarette = Bionic Spinarette
+trait-description-Spinarette =
+    This vatgrown organ-- trademarked and patented by the Cybersun Corporation, is marketed as a highly
+    utilitarian enhancement, and sold in clinics all across known space. It consists of a nodule that is traditionally
+    implanted right below the wrist, which absorbs bodily lipids to convert into all natural silk. A small opening
+    in the palm allows the user to 'spin' this thread. Users of this enhancement typically require twice as much food
+    as a standard Sol Human, owing to the high metabolic cost of artificial Sericulture.
+
 trait-name-AddictionNicotine = Nicotine Addiction
 trait-description-AddictionNicotine =
-    You have an addiction to Nicotine, and will require frequent smoke breaks to keep your mood in check.
+    You have an addiction to Nicotine, and will require frequent smoke breaks to keep your mood in check.

Resources/Prototypes/Traits/disabilities.yml

@@ -191,3 +191,41 @@
       damageModifiers:
         coefficients:
           Blunt: 1.1
+
+- type: trait
+  id: Photophobia
+  category: Visual
+  points: 1
+  requirements:
+    - !type:CharacterSpeciesRequirement
+      inverted: true
+      species:
+        - Vulpkanin # This trait functions exactly as-is for the Vulpkanin trait.
+  components:
+    - type: Flashable
+      eyeDamageChance: 0.3
+      eyeDamage: 1
+      durationMultiplier: 1.5
+
+- type: trait
+  id: Clumsy
+  category: Physical
+  points: 1
+  requirements:
+    - !type:CharacterJobRequirement
+      inverted: true
+      jobs:
+        - Clown # This trait functions exactly as is for the Clown's trait.
+    - !type:CharacterDepartmentRequirement
+      inverted: true
+      departments:
+        - Command # Because I know for a fact people will play Captain and grief with their inability to fight back.
+        - Security # Because I know for a fact people will play Security and grief with their inability to use guns.
+  components:
+    - type: Clumsy
+      clumsyDamage:
+        types:
+          Blunt: 5
+          Piercing: 4
+        groups:
+          Burn: 3

Resources/Prototypes/Traits/physical.yml

@@ -231,3 +231,173 @@
           Blunt: 1.5
           Slash: 1.5
           Piercing: 1.5
+
+- type: trait
+  id: Small
+  category: Physical
+  points: -2
+  requirements:
+    - !type:CharacterSpeciesRequirement
+      inverted: true
+      species:
+        - Felinid # Felinids already have this feature by default.
+    - !type:CharacterHeightRequirement
+      max: 150
+    - !type:CharacterWidthRequirement
+      max: 32
+  components:
+    - type: PseudoItem
+      storedOffset: 0,17
+      shape:
+        - 0,0,1,4
+        - 0,2,3,4
+        - 4,0,5,4
+
+- type: trait
+  id: TemperatureTolerance
+  category: Physical
+  points: -1
+  requirements:
+    - !type:CharacterSpeciesRequirement
+      inverted: true
+      species:
+        - Vulpkanin # This trait functions exactly as-is for the Vulpkanin trait.
+  components:
+    - type: TemperatureProtection
+      coefficient: 0.1 # Enough resistance to walk into the chef's freezer, or tolerate daytime temperatures on Glacier without a jacket.
+
+# These traits largely exist to demonstrate more of the "Component Removals" functionality. This way contributors
+# can get used to seeing that they can "Remove and Replace" a pre-existing component.
+# When declared, componentRemovals work like a "RemComp" that activates upon joining a round.
+- type: trait
+  id: Talons
+  category: Physical
+  points: -1
+  requirements:
+    - !type:CharacterSpeciesRequirement
+      inverted: true
+      species:
+        - Harpy # Harpies already have talons
+        - Arachnid # Apparently they have a "piercing" bite
+    - !type:CharacterTraitRequirement
+      inverted: true
+      traits:
+        - Claws
+  componentRemovals:
+    - MeleeWeapon # Remove the original innate melee attack, so that it can be replaced with a new one.
+  components:
+    - type: MeleeWeapon
+      soundHit:
+        collection: AlienClaw
+      animation: WeaponArcClaw
+      damage:
+        types:
+          Piercing: 5 # No, this isn't "OP", this is literally the worst brute damage type in the game.
+                      # Same deal as Slash, except that a majority of all armor provides Piercing resistance.
+
+- type: trait
+  id: Claws
+  category: Physical
+  points: -1
+  requirements:
+    - !type:CharacterSpeciesRequirement
+      inverted: true
+      species:
+        - Felinid # Felinids already have cat claws.
+        - Reptilian # Reptilians also have cat claws.
+        # - Vulpkanin # Vulpkanin have "Blunt" claws. One could argue this trait "Sharpens" their claws.
+    - !type:CharacterTraitRequirement
+      inverted: true
+      traits:
+        - Talons
+  componentRemovals:
+    - MeleeWeapon # Remove the original innate melee attack, so that it can be replaced with a new one.
+  components:
+    - type: MeleeWeapon
+      soundHit:
+        collection: AlienClaw
+      angle: 30
+      animation: WeaponArcClaw
+      damage:
+        types:
+          Slash: 5 # Trade stamina damage on hit for a very minor amount of extra bleed.
+                   # Blunt also deals bleed damage, so this is more of a sidegrade.
+
+- type: trait
+  id: NaturalWeaponRemoval
+  category: Physical
+  points: 0
+  requirements:
+    - !type:CharacterSpeciesRequirement
+      inverted: true
+      species:
+        - Human
+        - Oni
+        - SlimePerson
+    - !type:CharacterTraitRequirement
+      inverted: true
+      traits:
+        - Talons
+        - Claws
+  componentRemovals:
+    - MeleeWeapon # Remove the original innate melee attack, so that it can be replaced with a new one.
+  components:
+    - type: MeleeWeapon
+      soundHit:
+        collection: Punch
+      angle: 30
+      animation: WeaponArcFist
+      damage:
+        types:
+          Blunt: 5
+
+- type: trait
+  id: StrikingCalluses
+  category: Physical
+  points: -4
+  requirements:
+    - !type:CharacterSpeciesRequirement
+      species:
+        - Human # Entirely arbitrary, I've decided I want a trait unique to humans. Since they don't normally get anything exciting.
+                # When we get the Character Records system in, I also want to make this require certain Backgrounds.
+    - !type:CharacterTraitRequirement
+      inverted: true
+      traits:
+        - Claws
+        - Talons
+    - !type:CharacterLogicOrRequirement
+      requirements:
+        - !type:CharacterTraitRequirement
+          traits:
+            - MartialArtist
+        - !type:CharacterJobRequirement
+          jobs:
+            - Boxer
+  componentRemovals:
+    - MeleeWeapon
+  components:
+    - type: MeleeWeapon
+      soundHit:
+        collection: Punch
+      angle: 30
+      animation: WeaponArcFist
+      damage:
+        types:
+          Blunt: 6
+
+- type: trait
+  id: Spinarette
+  category: Physical
+  points: -4
+  requirements:
+    - !type:CharacterSpeciesRequirement
+      inverted: true
+      species:
+        - Arachnid
+        - Arachne
+  components:
+    - type: Sericulture
+      action: ActionSericulture
+      productionLength: 2
+      entityProduced: MaterialWebSilk1
+      hungerCost: 4