Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Sucks #474

Open
2 of 8 tasks
DEATHB4DEFEAT opened this issue Jun 18, 2024 · 0 comments
Open
2 of 8 tasks

Audio Sucks #474

DEATHB4DEFEAT opened this issue Jun 18, 2024 · 0 comments
Labels
Priority: 4-Low Should be resolved at some point Size: 2-Large For large issues/PRs Size: 3-Medium For medium issues/PRs Status: Help Wanted Extra attention is needed Status: Needs Discussion Must be discussed Type: Cleanup Like Rework but small Type: Codebase An issue with the codebase

Comments

@DEATHB4DEFEAT
Copy link
Member

DEATHB4DEFEAT commented Jun 18, 2024

Description

Audio kinda sucks and has for maybe ever.
Especially since the audio rework.
There's a lack of sliders for specific sounds, everything is on Master except for a couple of things that don't matter much.
I keep running into the issue of joining a modern codebase after playing old Parkstation and hating how loud and how quiet random things are that are all bunched into Master audio, and just end up turning everything down a ton.
Even if things weren't weirdly volumed, everything is just so much louder between before and after the audio rework, it's annoying reconfiguring my settings between the two.
The issue of playing the different codebases isn't a very big one, and is definitely not one most players will have, especially not for long as old servers die or modernize.

The Needs Discussion and Help Wanted tags are here for a reason, please comment.

General issues

  • Event music and announcements are very loud
  • Admin audio is just a toggle
  • Machine and other ambience not from the newish background ambience system or whatever are only in the Master channel but should probably be in their own or the existing Ambience one
    • What does the Ambience Max Sounds slider do/does it matter or need to exist? And why is it not near the Ambience slider?
  • Lobby & Round-end Music should just be a slider instead of a toggle, or have them next to each other in a compact way
    • Same with everything else

Odd sounds

  • Plastic water bottles shouldn't have the glass sound effect

Oddly loud/quiet sounds

@DEATHB4DEFEAT DEATHB4DEFEAT added Priority: 4-Low Should be resolved at some point Size: 3-Medium For medium issues/PRs Size: 2-Large For large issues/PRs Status: Needs Discussion Must be discussed Status: Help Wanted Extra attention is needed Type: Codebase An issue with the codebase Type: Cleanup Like Rework but small labels Jun 18, 2024
DangerRevolution added a commit that referenced this issue Jul 1, 2024
# Description

Part of #467, #460, and #474

This is a small PR that corrects a math error in SharedGunSystem,
causing shell casings to be "Thrown" directly downwards instead of in an
actually cinematic and exciting arc. While I'm at it, I also corrected
the fixture of base shell casings to favor "Bounciness", and decreased
its mass to approximately 100 grams. Finally, I added a sound for when
casings bounce off of walls, which wasn't present before.


https://github.com/Simple-Station/Einstein-Engines/assets/16548818/56bb4ecc-d5eb-4b36-853b-42f05374150d

🆑
- fix: Spent bullet casings now fly away from a shooter in a cinematic
manner, rather than fall at their feet.

Co-authored-by: Danger Revolution! <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 4-Low Should be resolved at some point Size: 2-Large For large issues/PRs Size: 3-Medium For medium issues/PRs Status: Help Wanted Extra attention is needed Status: Needs Discussion Must be discussed Type: Cleanup Like Rework but small Type: Codebase An issue with the codebase
Projects
None yet
Development

No branches or pull requests

1 participant