Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Spent Casing Ejection Not Suck #478

Merged

Conversation

VMSolidus
Copy link
Member

Description

Part of #467, #460, and #474

This is a small PR that corrects a math error in SharedGunSystem, causing shell casings to be "Thrown" directly downwards instead of in an actually cinematic and exciting arc. While I'm at it, I also corrected the fixture of base shell casings to favor "Bounciness", and decreased its mass to approximately 100 grams. Finally, I added a sound for when casings bounce off of walls, which wasn't present before.

BetterCasings.mp4

🆑

  • fix: Spent bullet casings now fly away from a shooter in a cinematic manner, rather than fall at their feet.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Jun 19, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Maybe one day wall hitboxes won't suck lol

@github-actions github-actions bot added the Status: Needs Review Someone please review this label Jun 20, 2024
@DangerRevolution DangerRevolution added Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Type: Cleanup Like Rework but small labels Jun 20, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT mentioned this pull request Jun 24, 2024
8 tasks
@DangerRevolution DangerRevolution merged commit ba2d538 into Simple-Station:master Jul 1, 2024
11 checks passed
SimpleStation14 added a commit that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Status: Needs Review Someone please review this Type: Cleanup Like Rework but small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants