Traits V2 #1182
Merged
Traits V2 #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: C#
gluesniffler
reviewed
Nov 6, 2024
Co-authored-by: gluesniffler <[email protected]> Signed-off-by: VMSolidus <[email protected]>
VMSolidus
requested review from
Aidenkrz,
FoxxoTrystan,
Remuchi,
DEATHB4DEFEAT,
Peptide90,
OldDanceJacket and
SimpleStation14
|
It's finally ready. |
FoxxoTrystan
added
Priority: 2-High
FoxxoTrystan
approved these changes
Nov 7, 2024
| [DataField] | ||
| public List<string>? RemoveFactions { get; private set; } = default!; | ||
| [DataField(serverOnly: true)] | ||
| public TraitFunction[] Functions { get; private set; } = Array.Empty<TraitFunction>(); |
There was a problem hiding this comment.
No idea to be honest, I had no idea what was entirely essential for this style of setup, so it's exactly how it was with the JobSpecial.
There was a problem hiding this comment.
Both can be used. Since it's fixed length (you will not change it via VVEdit or in code) array is fine to be used here.
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: VMSolidus <[email protected]>
Remuchi
previously requested changes
Nov 8, 2024
| [DataField] | ||
| public List<string>? RemoveFactions { get; private set; } = default!; | ||
| [DataField(serverOnly: true)] | ||
| public TraitFunction[] Functions { get; private set; } = Array.Empty<TraitFunction>(); |
There was a problem hiding this comment.
Both can be used. Since it's fixed length (you will not change it via VVEdit or in code) array is fine to be used here.
Peptide90
approved these changes
Nov 8, 2024
sleepyyapril
pushed a commit
to sleepyyapril/Einstein-Engines
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Traits Version 2 implements a much needed overhaul of the Trait System, changing it so that it no longer uses hardcoded nullable lists of various entries required for the trait functions, and instead accepts a single Modular List of Functions, and then iterates through the list like a set of instructions on how to modify the character. This PR also features a few new Functions, such as AddImplant.
Anyway, rather than hardcoding a new codepath for every new function, new functions can simply be made separate from the codepath entirely, and will only be called if they are included in the trait itself.
TODO
BREAKING CHANGES
ALL DOWNSTREAM TRAITS WILL NEED TO BE MODIFIED TO USE THE NEW SYSTEM.
Changelog
🆑