Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Fix shield absorbing asphyxiation damage #140

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #25972: Fix shield absorbing asphyxiation damage from space-wizards space-wizards/space-station-14

b0ffed1607452a2d4186228fc2343d10035611e5

PR opened by nikthechampiongr at 2024-03-10 17:36:06 UTC
PR merged by web-flow at 2024-03-11 01:55:19 UTC


PR changed 1 files with 12 additions and 2 deletions.

The PR had the following labels:


Original Body

fixes #25966

About the PR

The shield will now only reduce damage itself can absorb.

Why / Balance

A shield should probably not oxygenate your blood supply.

Technical details

Instead of just multiplying the damage of the user, we now create a damagemodiferset with all the damages that the shield can take. For that we use the shield's damageable component. This does mean that shields that cannot take damage will no longer absorb damage.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • fix: Shields will no longer absorb asphyxiation damage, or any other damage they themselves can't take.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 4, 2024 23:33
@VMSolidus VMSolidus enabled auto-merge (squash) May 5, 2024 00:22
@VMSolidus VMSolidus merged commit 2190585 into Simple-Station:master May 5, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants