Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Fix RUN_THIS.py so it would be cross-platform and it would be possible to use it from cmd on Windows #153

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26017: Fix RUN_THIS.py so it would be cross-platform and it would be possible to use it from cmd on Windows from space-wizards space-wizards/space-station-14

7ed94f8824d455cab2c712eb952312c4e8fd7c52

PR opened by CrafterKolyan at 2024-03-11 22:02:53 UTC
PR merged by web-flow at 2024-03-12 00:02:41 UTC


PR changed 1 files with 1 additions and 6 deletions.

The PR had the following labels:

  • No C#

Original Body

About the PR

I'm not sure why it was decided to do this weird setup with py -3 on Windows cygwin when there's sys.executable which contains the full absolute path to the current python3 that executes the current script.

Technical details

Everything works correctly:

Hooks need updating.
Copying hook post-checkout
Copying hook post-merge
$ git submodule update --init --recursive
Submodule 'RobustToolbox' (https://github.com/space-wizards/RobustToolbox.git) registered for path 'RobustToolbox'
Cloning into 'C:/Workspace/SpaceStation14/space-station-14/RobustToolbox'...
Submodule path 'RobustToolbox': checked out '2b6381c332793b6207db2d865234674f36824bbe'
Submodule 'Lidgren.Network' (https://github.com/space-wizards/lidgren-network-gen3.git) registered for path 'RobustToolbox/Lidgren.Network/Lidgren.Network'
Submodule 'NetSerializer' (https://github.com/space-wizards/netserializer) registered for path 'RobustToolbox/NetSerializer'
Submodule 'Robust.LoaderApi' (https://github.com/space-wizards/Robust.LoaderApi.git) registered for path 'RobustToolbox/Robust.LoaderApi'
Submodule 'XamlX' (https://github.com/space-wizards/XamlX) registered for path 'RobustToolbox/XamlX'
Submodule 'cefglue' (https://github.com/space-wizards/cefglue.git) registered for path 'RobustToolbox/cefglue'
Cloning into 'C:/Workspace/SpaceStation14/space-station-14/RobustToolbox/Lidgren.Network/Lidgren.Network'...
Cloning into 'C:/Workspace/SpaceStation14/space-station-14/RobustToolbox/NetSerializer'...
Cloning into 'C:/Workspace/SpaceStation14/space-station-14/RobustToolbox/Robust.LoaderApi'...
Cloning into 'C:/Workspace/SpaceStation14/space-station-14/RobustToolbox/XamlX'...
Cloning into 'C:/Workspace/SpaceStation14/space-station-14/RobustToolbox/cefglue'...
Submodule path 'RobustToolbox/Lidgren.Network/Lidgren.Network': checked out '45f89ca2639ec05d4700691a1160fccd79cb4c86'
Submodule path 'RobustToolbox/NetSerializer': checked out '7f51deaecab8498a8953f7fb3e551b9892c5dff4'
Submodule path 'RobustToolbox/Robust.LoaderApi': checked out '99a2f4b88077629f69fb66f74f50e88dbe43e0e8'
Submodule path 'RobustToolbox/XamlX': checked out 'dca5a5f8c2759b940a87449584724ec71aa0dd19'
Submodule path 'RobustToolbox/cefglue': checked out 'e265d67a21d0e526178f72326bd45f36d85ad6ca'

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@stellar-novas
Copy link
Contributor

+1 looks good.

@DangerRevolution DangerRevolution requested review from DEATHB4DEFEAT and a team May 11, 2024 20:53
@github-actions github-actions bot added the Status: Needs Review Someone please review this label May 11, 2024
@DangerRevolution DangerRevolution added Changes: Config Changes any configuration files Priority: 2-High Needs to be resolved as soon as possible Size: 4-Small For small issues/PRs Type: Codebase An issue with the codebase labels May 11, 2024
@VMSolidus VMSolidus marked this pull request as ready for review May 12, 2024 04:06
@VMSolidus VMSolidus merged commit abe7f55 into Simple-Station:master May 12, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Config Changes any configuration files Priority: 2-High Needs to be resolved as soon as possible Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot Size: 4-Small For small issues/PRs Status: Needs Review Someone please review this Type: Codebase An issue with the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants