Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Add fancy table spawner #170

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26044: Add fancy table spawner from space-wizards space-wizards/space-station-14

f5f5eebeeeee005a955ebd2814b4b9d6204e72ef

PR opened by IamVelcroboy at 2024-03-12 16:09:24 UTC
PR merged by web-flow at 2024-03-13 06:21:51 UTC


PR changed 1 files with 22 additions and 0 deletions.

The PR had the following labels:

  • No C#

Original Body

About the PR

Adds fancy table spawner for mapping random fancy tables

Why / Balance

Nice

Technical details

n/a

Media

n/a

  • I have added screenshots/videos to this PR showcasing its changes in-game, or this PR does not require an in-game showcase

Breaking changes

n/a

Changelog
n/a

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
@VMSolidus
Copy link
Member

Ah nice, here it is. The PR we needed in order to merge the DV patches.

Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

All tests pass on localhost tests. Going to request this one get reviewed first because it's the pre-requisite for the entire pile of DeltaV mirrors.

@DEATHB4DEFEAT
Copy link
Member

image

All tests pass on localhost tests. Going to request this one get reviewed first because it's the pre-requisite for the entire pile of DeltaV mirrors.

Did you do YAMLLinter and Tests too?

@VMSolidus
Copy link
Member

Are those separate commands from Dotnet Test? I was under the impression Test runs the linters too?

@DEATHB4DEFEAT
Copy link
Member

Are those separate commands from Dotnet Test? I was under the impression Test runs the linters too?

I've never used dotnet test.
There are (annoyingly) three different projects that all run different tests; Tests, IntegrationTests, and YAMLLinter.

@VMSolidus VMSolidus merged commit e49e813 into Simple-Station:master Apr 23, 2024
11 checks passed
ShatteredSwords pushed a commit to ShatteredSwords/Einstein-Engines that referenced this pull request Sep 2, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants