Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Syringe doafter based on Syringe contents #176

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #25890: Syringe doafter based on Syringe contents from space-wizards space-wizards/space-station-14

37cd12524e85b6a3b31827e4751a94ca51268694

PR opened by Plykiya at 2024-03-06 21:57:17 UTC
PR merged by web-flow at 2024-03-13 09:35:48 UTC


PR changed 1 files with 14 additions and 2 deletions.

The PR had the following labels:


Original Body

About the PR

Altered the additional doafter time penalty to be based on what's actually in the syringe rather than what you have the TransferAmount set to for both drawing and injecting.

Why / Balance

It just makes sense.. honestly though, if I could change the total do-after time to something less than five seconds I would, but I know that for balance reasons it's probably not good to be able to inject someone in like one second with 1u of content. That would be infringing on the territory of hypospray speed for self-injections...

I think the equation for calculating the additional do-after was wrong or I'm just really bad at math. I fixed it based on what the comment intended.

Technical details

Altered do-after equation to be based on empty space when drawing and current content amount when injecting.

Media

  • [ X ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Additional syringe doafter delay is now based on syringe contents rather than transfer amount setting.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 4, 2024 23:58
@VMSolidus VMSolidus enabled auto-merge (squash) May 5, 2024 00:30
@VMSolidus VMSolidus merged commit 8589df5 into Simple-Station:master May 5, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants