Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Fix Butcherable handling, ItemSlots for clown shoes #180

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #25661: Fix Butcherable handling, ItemSlots for clown shoes from space-wizards space-wizards/space-station-14

674b42b3a0ab9fa607887c1401f38ca1f8bb3911

PR opened by Krunklehorn at 2024-02-28 02:04:52 UTC


PR changed 9 files with 75 additions and 30 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

About the PR

  • Fixes improper popups with edible+butcherable items, and sharp+utensil items
  • Clown shoes have item slots
    • Intended for non-harmful items other than their job specific gun
    • Currently supports plastic knives, cap gun & fake cap gun

Minor stuff...

  • Spoons are metal
  • Plastic knives are actually plastic knives
  • Plastic utensils are now zero damage weapons
  • Raw rat meat is sliceable

Why / Balance

Funny suggestion, but also a legitimate way for a Clown to sneak their job specific gun into a holding cell/perma.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑 Krunk

  • add: Clown & Jester shoes can now hold plastic knives and cap guns! All clowning, all the time!

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 6, 2024 18:49
@VMSolidus VMSolidus merged commit 467b21a into Simple-Station:master May 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants