Mirror: Trading Outpost now has half buy-only and half sell-only pallets

[SimpleStation14]

Mirror of PR #25955: Trading Outpost now has half buy-only and half sell-only pallets from space-wizards/space-station-14

c0bbbc33c19eafcc8defaa7f1ec2df42e485b435

PR opened by wafehling at 2024-03-10 02:47:02 UTC

---

PR changed 8 files with 226 additions and 123 deletions.

The PR had the following labels:

• Changes: Sprites
• Status: Needs Review

---

Original Body

About the PR

I added two new entity types, a buy and sell only cargo pallet, and added them to the trading outpost in place of the old pallets.

Why / Balance

Since the day this was added, every single shift, at some point I'll hear someone in cargo yelling about how "You sold stuff I just bought!"

This seemed like the easiest way to fix the problem.

Technical details

Added a variable to the cargo pallet component for labeling which type it is, added two new varieties of the cargo pallet to the yml, and adjusted all the calls for GetCargoPallets() to have boolean variables for buyOnly and sellOnly to tell the function what kind of call you're looking for.

If you don't give it any specifics it'll still treat any pallet as a two-way one, but this function is only called 2 or 3 times and I've adjusted them all and commented the function itself for anyone looking to change/add it in the future.

The old pallet is still in the game and is set to "both" by default, so it should work just fine for backwards compatibility.

Media

• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Shouldn't break anything, I've left the old pallets fully in, and updated them to work with the new GetCargoPallets() function just like they used to. Not sure if/where you'd still need them, but better safe than sorry.

Changelog
🆑

• tweak: The trading outpost now has dedicated buy-only and sell-only pallets. No more accidentally selling orders you just bought. Cargonians rejoice!

[github-actions]

RSI Diff Bot; head commit 84750db merging into 3bf08c7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/cargo_pallets.rsi

State	Old	New	Status
cargo_pallet_buy			Added
cargo_pallet_sell			Added

[DangerRevolution]

this needs to be tested to work on Delta trade station

[VMSolidus]

The C# side of things is fine, and it does also modify the tradepost grid to add these new pallets.

[DangerRevolution]

Will be merged if tests pass