Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Drink from closed container fix #195

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26103: Drink from closed container fix from space-wizards space-wizards/space-station-14

2f2cd4aab70703717541e5db3f46ae4831b4129d

PR opened by maylokana at 2024-03-14 03:59:47 UTC


PR changed 1 files with 3 additions and 0 deletions.

The PR had the following labels:


Original Body

About the PR

All drink containers now check if the container is closed once the do-after is done, and will stop you from trying to drink from it if it is closed

Why / Balance

Bug fix. I think

Technical details

In DrinkSystem.cs, added an _openable.IsClosed() method to OnDoAfter(), which returns if true

Media

bottlefix.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

N/A

Changelog

🆑

  • fix: Entities can no longer drink from closed containers

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 6, 2024 18:48
@VMSolidus VMSolidus merged commit d34c52f into Simple-Station:master May 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants