Mirror: StrippableSystem doafter overhaul

[SimpleStation14]

Mirror of PR #25994: StrippableSystem doafter overhaul from space-wizards/space-station-14

41ca8f3dfcb986432e1e509247bf239cac137836

PR opened by Krunklehorn at 2024-03-11 12:36:28 UTC

---

PR changed 7 files with 465 additions and 305 deletions.

The PR had the following labels:

• Status: Needs Review

---

Original Body

About the PR

Refactors Strippable DoAfter events to make them synchronous and organized.

Technical details

Strippable System & Component

• Synchronous DoAfters
• Made use of TimeSpan, GetStripTimeModifiers() and ByRefEvent
• Reorganized checks, removed some redundant ones
• Resolve pattern where useful
• Added more asserts
• Lots of cleanup

The DoAfters were grouped under one event to avoid copy-pasting eight separate cancel checks, asserts and function signatures.

Let me know if this is bad for performance and I'll roll them out instead.

Media

• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

TimeSpans

ThievingComponent, InventoryTemplatePrototype and ToggleableClothingSystem use TimeSpan in places where they intersect with StrippableComponent.

Changelog

N/A

[DangerRevolution]

needs to be checked with Felinid changes (not sure if merged / reverted here)

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[VMSolidus]

Going to approve this since we have both the fix PR, as well as a new PR reworking the thieving system to go with it.