Mirror: Fix anomaly decay logs

[SimpleStation14]

Mirror of PR #26180: Fix anomaly decay logs from space-wizards/space-station-14

d8a7b33b43cd9b0e241dc189653cbd4cf4c49086

PR opened by LordCarve at 2024-03-16 17:05:24 UTC

---

PR changed 1 files with 3 additions and 2 deletions.

The PR had the following labels:

• Status: Needs Review

---

Original Body

About the PR

• Decayed Anomalies leave log with LogImpact.Low (down from LogImpact.Extreme and being misreported as having gone supercritical)
  Reason: Admin Logs severity usually means how much of admin attention this requires. A decayed anomaly does not require any Admin attention and is essentially just a convenience note.

• Swapped LogImpacts of supercritical event starting and finishing.
  Reason: When an anomaly starts going supercritical it leaves a log with LogImpact.High, but when it finishes the animation it leaves a log with LogImpact.Extreme. This seems inconsistent to me, because the moment anomaly starts going supercritical seems to demand more Admin attention than an "it had already happened"-style report. After this change, a supercritical anomaly will still always leave at least one LogImpact.Extreme admin log, so from reporting perspective it should be conveying the same message;, but from "immediate responder" perspective Admins get the more-important Extreme log sooner (as the supercritical event starts happening, rather than after it had already finished).

Resolves #26122

Why / Balance

Bugfix.

Technical details

Anomalies ending still leave multiple logs. This is beyond the scope of this PR.
But at least now it won't spam the LogImpact.Extreme category.

Media

• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑
ADMIN

• fix: Decayed anomalies no longer show as having gone supercritical in logs.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.