Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror: Pulling Rework V2 #269

Merged
merged 7 commits into from
Jul 9, 2024
Merged

Mirror: Pulling Rework V2 #269

merged 7 commits into from
Jul 9, 2024

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #24936: Pulling rework v2 from space-wizards space-wizards/space-station-14

c584f6444a85cc53edb060230f7e7b2b76cc87bf

PR opened by metalgearsloth at 2024-02-04 01:43:17 UTC

PR changed 53 files with 796 additions and 1356 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

Health v2 moment

Fixes space-wizards/space-station-14#24900

  • Fixes container changes.
  • Fixes keybind.
  • Fixes multi-pull.
  • Fixes alerts cleanup for non-predicted pull stops.

I'm awake now for any issues.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
DangerRevolution
DangerRevolution suggested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reports on Delta of this causing issues with things being floaty, should be tested

@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:12
@DangerRevolution DangerRevolution marked this pull request as ready for review May 28, 2024 23:58
DangerRevolution
DangerRevolution approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine enough i guess, whatever issues caused on delta i assume would be ironed out on Wiz soon

@github-actions github-actions bot added Changes: C# Changes any cs files Status: Needs Review Someone please review this labels May 29, 2024
@SimpleStation14 SimpleStation14 changed the title Mirror: Pulling rework v2 Mirror: Pulling Rework V2 Jul 9, 2024
@VMSolidus
Copy link
Member

Need to find the PR that moves the NoShoesSilentFootstepsComponent, and then merge that PR into this one.

@VMSolidus
Copy link
Member

Found it. It was actually a DeltaV change, and was missing a Using.

@VMSolidus VMSolidus merged commit 24f36c1 into Simple-Station:master Jul 9, 2024
11 checks passed
@FoxxoTrystan FoxxoTrystan mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DangerRevolution DangerRevolution DangerRevolution approved these changes

@VMSolidus VMSolidus VMSolidus approved these changes

@DEATHB4DEFEAT DEATHB4DEFEAT Awaiting requested review from DEATHB4DEFEAT

@Pspritechologist Pspritechologist Awaiting requested review from Pspritechologist

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pulling is completly fucked
3 participants
@SimpleStation14 @VMSolidus @DangerRevolution