Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Fix wire layout inheritance. #284

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26289: Fix wire layout inheritance. from space-wizards space-wizards/space-station-14

a4692004de978cda6761d4090e13ed4d8bc1fa11

PR opened by PJB3005 at 2024-03-20 14:42:55 UTC


PR changed 2 files with 105 additions and 0 deletions.

The PR had the following labels:


Original Body

Wire layouts manually navigate the inheritance hierarchy, but the data fields on the prototypes were also automatically inherited already. This meant that inheriting a wire layout prototype and changing nothing would cause the wires to be duplicated unless they were manually modified on top.

Fix is easy: just disable inheritance on the data fields.

Also, integration test for it.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:12
@DangerRevolution DangerRevolution marked this pull request as ready for review May 28, 2024 23:56
@DangerRevolution DangerRevolution requested a review from a team May 28, 2024 23:56
@DangerRevolution DangerRevolution added Changes: C# Changes any cs files Changes: Config Changes any configuration files Priority: 3-Medium Needs to be resolved at some point Status: Needs Review Someone please review this Type: Codebase An issue with the codebase labels May 28, 2024
@DangerRevolution
Copy link
Contributor

this actually changes content tests so just want @DEATHB4DEFEAT to look at it

@github-actions github-actions bot removed the Changes: Config Changes any configuration files label May 28, 2024
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It adds a new content integration test, which runs just fine.

@VMSolidus VMSolidus merged commit 5c2cff0 into Simple-Station:master May 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Priority: 3-Medium Needs to be resolved at some point Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot Status: Needs Review Someone please review this Type: Codebase An issue with the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants