Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Throwing Knives: Syndicate Kit #310

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26026: Throwing Knives: Syndicate Kit from space-wizards space-wizards/space-station-14

393bcbfc1346589075ad960473685c78bdbf46e5

PR opened by UbaserB at 2024-03-12 06:57:41 UTC


PR changed 13 files with 101 additions and 8 deletions.

The PR had the following labels:

  • No C#
  • Changes: Sprites

Original Body

About the PR

This PR adds throwing knives and a syndicate bundle in the bundle category for 6 TC which comes with 4 throwing knives in a box. Each knife does 10 slash + 15 pierce damage on throw, and 5 flash per hit (10 DPS). This makes it better than a kitchen knife, but worse than a combat knife, which is what security is fitted with.

Why / Balance

This kit is built for weakening an enemy from a distance (from chasing, etc) while being able to fight back if cornered into a 1v1 CQC fight. Sure, you can kill several people with the kit; hence why it's so expensive, but there are drawbacks. Firstly, once it embeds into a target they are able to pull it out. Secondly, when you are pulling them out of a target, YOU are vulnerable. Thirdly, if you miss your hits the target will probably not die. Good things you have four knives and can stab them to death.. better than punches!

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

It embeds and kills in 4 throws on an unarmoured target.
image

Item description.
image

4 knives.
image

Kit on uplink.
[IMG NEEDS UPDATING]

Changelog

🆑 Ubaser

  • add: You can now purchase a set of 4 throwing knives in the uplink as a bundle for 12 TC.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
Copy link
Contributor

github-actions bot commented Apr 22, 2024

RSI Diff Bot; head commit ac677ba merging into 4fdfd6f
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Storage/boxes.rsi

State Old New Status
throwing_knives Added

Resources/Textures/Objects/Storage/boxicons.rsi

State Old New Status
throwing_knives Added

Resources/Textures/Objects/Weapons/Melee/throwing_knife.rsi

State Old New Status
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after ac677ba

Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this overwrite observation kit lol

@VMSolidus
Copy link
Member

why does this overwrite observation kit lol

Because that's just the main downside of how mirrors work. Technically things like this also happen while cherrypicking. I'm trying to work things out with Death and Pspsrite so that full Maintainers can actually make edits to the Mirror PRs to fix issues like these. Trial maintainers should be able to make code suggestions to fix issues like this, and then a full maintainer can come in and hit commit on said suggestions.

@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:12
@VMSolidus VMSolidus marked this pull request as ready for review May 29, 2024 01:11
@github-actions github-actions bot added Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files labels May 29, 2024
@DangerRevolution DangerRevolution merged commit 0269efc into Simple-Station:master Jun 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants