Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror: Admin New Player Notification Sound #318

Merged
merged 1 commit into from
May 5, 2024
Merged

Mirror: Admin New Player Notification Sound #318

merged 1 commit into from
May 5, 2024

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #24327: Admin New Player Notification Sound from space-wizards space-wizards/space-station-14

b9db06ebb1af41f2809f6c31dc4990b6a729d041

PR opened by DEATHB4DEFEAT at 2024-01-20 06:59:20 UTC

PR changed 4 files with 20 additions and 0 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

Description

Ported from Parkstation.
Adds a brief sound that plays whenever a player joins for the first time.

Media

2024-01-19_22-38-03.mp4

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
DangerRevolution
DangerRevolution approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good, lets you spawncamp new players

@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:12
This was referenced May 5, 2024
Merged
Open
@VMSolidus VMSolidus marked this pull request as ready for review May 5, 2024 18:48
VMSolidus
VMSolidus approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, now admins will know when to keep an eye out for arrivals.

@VMSolidus VMSolidus merged commit afe9415 into Simple-Station:master May 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DangerRevolution DangerRevolution DangerRevolution approved these changes

@VMSolidus VMSolidus VMSolidus approved these changes

Assignees
No one assigned
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimpleStation14 @VMSolidus @DangerRevolution