Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror: haunted dungeon template #321

Merged
merged 1 commit into from
May 12, 2024
Merged

Mirror: haunted dungeon template #321

merged 1 commit into from
May 12, 2024

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #23768: haunted dungeon template from space-wizards space-wizards/space-station-14

952b7f4c4e8e957c0c3765f7b20f2745c9297e27

PR opened by Emisse at 2024-01-09 07:36:29 UTC

PR changed 17 files with 4009 additions and 67 deletions.

The PR had the following labels:

Original Body

also for sloth when he gets to it

Requires space-wizards/RobustToolbox#4980

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
DangerRevolution
DangerRevolution reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hard to say without actually playing on this

@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:12
@VMSolidus VMSolidus marked this pull request as ready for review May 9, 2024 04:59
@VMSolidus VMSolidus marked this pull request as draft May 10, 2024 01:46
@VMSolidus VMSolidus marked this pull request as ready for review May 10, 2024 01:46
VMSolidus
VMSolidus approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having checked it ingame, it's actually fine. The gimmick is basically abandoned mineshafts with some spooky cult stuff hidden away in secret alcoves, think like horror movie aesthetic.

@DangerRevolution DangerRevolution added Changes: C# Changes any cs files Changes: Map Changes any yml file in the Maps directories Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 2-Large For large issues/PRs Type: Feature Creation of or significant changes to a feature labels May 11, 2024
@DangerRevolution
Copy link
Contributor

fine to merge if we have the pre-requisite robust toolbox PR merged from the description of the PR.

@VMSolidus VMSolidus merged commit 3b635f1 into Simple-Station:master May 12, 2024
23 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DangerRevolution DangerRevolution DangerRevolution approved these changes

@VMSolidus VMSolidus VMSolidus approved these changes

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: Map Changes any yml file in the Maps directories Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot Size: 2-Large For large issues/PRs Type: Feature Creation of or significant changes to a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimpleStation14 @DangerRevolution @VMSolidus