Supermatter Engine (Port From White Dream) #341

VMSolidus · 2024-04-25T02:56:35Z

Description

This PR has been produced in collaboration with coders from White Dream, with written permission given by the relevant code owners to port this specific slice of content to Einstein-Engines. Supermatter Engines are a form of nuclear reactor, which produces energy in the form of radioactive particles, while also decaying into Phoron when excited by an external energy source.

Power can be obtained from the engine via radiation collectors, which like those of a singularity engine, must be periodically refueled. In addition, the engine must also be actively cooled via aid from Atmospherics, and for undesirable gasses to be extracted from the reactor chamber.

If not cooled, the crystal will begin to destabilize and eventually collapse into one of three different situations depending on the source of its instability.

A nuclear blast.
A gravitational singularity
A Tesla ball

Changelog

🆑 VMSolidus, White Dream, Colin-Tel

add: Supermatter Engines have been implemented.

github-actions · 2024-04-25T02:57:11Z

RSI Diff Bot; head commit 10989f4 merging into b744818
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Supermatter/supermatter.rsi

State	Old	New	Status
supermatter			Added

Resources/Textures/Supermatter/supermatter_sliver.rsi

State	Old	New	Status
icon			Added

Edit: diff updated after 10989f4

VMSolidus · 2024-04-25T23:16:08Z

VMSolidus · 2024-04-26T04:26:25Z

Edge now includes an experimental Supermatter Engine, pending review from Colintel

Colin-Tel · 2024-04-26T12:12:08Z

After playing around with it for a bit, I am ecstatic thinking about the ~~disasters~~ gameplay that will result from this! I think it looks quite alright on Edge as is, however ~~I think we could afford maybe a few more plasma tanks for the SM area, and~~ I think instead of directing the distro air through the windows on both sides of the "SM command center," we could potentially have the lines both go through the command center instead.

I'm not totally resolute on that second part, as it's nice for the command center to just be a "computers and equipment" area rather than a "we check the physical pipes here too" area. I kind of like the way it's spread out.

So as far as the map is concerned, I am thoroughly enthused. I do think however there could be a distro vent and scrubber in the surrounding chamber, and there could be buttons inside the chamber that open/shut radiation shutters on specific sides.

Colin-Tel · 2024-04-26T13:52:25Z

Radiation Collectors' "help" button directs them to a guidebook page about the singularity. This would ideally be changed.

VMSolidus · 2024-04-26T22:32:08Z

Edge station has just gotten a new version, courtesy of @Colin-Tel . Thank you for working with us on this project!

DangerRevolution

This really should arc to Tesla posts, akin to the Tesla...

the main appeal for saying "Hey, come to EE we have that cool power source from 13!" is that people join, and it's like 13, maybe even expanded. Saying "oh this is kinda, half of what it was in 13" is meh.

DangerRevolution · 2024-04-30T22:05:38Z

This should also have a render of Edge.yml attached :)

VMSolidus · 2024-04-30T22:21:52Z

This really should arc to Tesla posts, akin to the Tesla...

the main appeal for saying "Hey, come to EE we have that cool power source from 13!" is that people join, and it's like 13, maybe even expanded. Saying "oh this is kinda, half of what it was in 13" is meh.

I would literally rather close the PR than make it a tesla clone.

DangerRevolution · 2024-04-30T22:22:32Z

This really should arc to Tesla posts, akin to the Tesla...
the main appeal for saying "Hey, come to EE we have that cool power source from 13!" is that people join, and it's like 13, maybe even expanded. Saying "oh this is kinda, half of what it was in 13" is meh.

I would literally rather close the PR than make it a tesla clone.

why not merge the two :) Tesla is just a cope supermatter

VMSolidus · 2024-04-30T22:23:23Z

This really should arc to Tesla posts, akin to the Tesla...
the main appeal for saying "Hey, come to EE we have that cool power source from 13!" is that people join, and it's like 13, maybe even expanded. Saying "oh this is kinda, half of what it was in 13" is meh.

I would literally rather close the PR than make it a tesla clone.

why not merge the two :) Tesla is just a SM cope

Tesla can stay SM cope because this is Baystation SM, not /tg/station SM. Being the atmos autism simulator is the main appeal of this version of the engine lol.

LovelyLophi · 2024-04-30T22:30:17Z

This really should arc to Tesla posts, akin to the Tesla...
the main appeal for saying "Hey, come to EE we have that cool power source from 13!" is that people join, and it's like 13, maybe even expanded. Saying "oh this is kinda, half of what it was in 13" is meh.

I would literally rather close the PR than make it a tesla clone.

why not merge the two :) Tesla is just a SM cope

Tesla can stay SM cope because this is Baystation SM, not /tg/station SM. Being the atmos autism simulator is the main appeal of this version of the engine lol.

I don't see why there couldn't be a scenario that makes the SM arc to tesla posts, would add more variety and options for the engineering team to power the station

DangerRevolution · 2024-04-30T22:32:03Z

This really should arc to Tesla posts, akin to the Tesla...
the main appeal for saying "Hey, come to EE we have that cool power source from 13!" is that people join, and it's like 13, maybe even expanded. Saying "oh this is kinda, half of what it was in 13" is meh.

I would literally rather close the PR than make it a tesla clone.

why not merge the two :) Tesla is just a SM cope

Tesla can stay SM cope because this is Baystation SM, not /tg/station SM. Being the atmos autism simulator is the main appeal of this version of the engine lol.

kinda real, can we re-enable Tesla :)

VMSolidus · 2024-04-30T22:32:35Z

This really should arc to Tesla posts, akin to the Tesla...
the main appeal for saying "Hey, come to EE we have that cool power source from 13!" is that people join, and it's like 13, maybe even expanded. Saying "oh this is kinda, half of what it was in 13" is meh.

I would literally rather close the PR than make it a tesla clone.

why not merge the two :) Tesla is just a SM cope

Tesla can stay SM cope because this is Baystation SM, not /tg/station SM. Being the atmos autism simulator is the main appeal of this version of the engine lol.

kinda real, can we re-enable Tesla :)

Oh absolutely, please do. I would love to see engine variety across maps.

DangerRevolution

pog: #350

VMSolidus · 2024-04-30T22:36:58Z

Yea I'm going to leave the minor feature list for a separate PR so that this won't PR bloat harder than it already has. We've deadass included a whole map rework in this PR, I'm not adding 6 new semi-unrelated items in addition to an entire new engine.

VMSolidus · 2024-07-30T23:44:44Z

@DEATHB4DEFEAT @Pspritechologist @Peptide90 @OldDanceJacket this is ready again for review. Please don't let it sit for a month unreviewed.

DEATHB4DEFEAT · 2024-07-30T23:47:38Z

* Add job whitelist system * Address reviews * Fix name * Apply suggestions from code review Co-authored-by: Pieter-Jan Briers <[email protected]> * cancinium --------- Co-authored-by: Pieter-Jan Briers <[email protected]>

VMSolidus · 2024-07-31T02:00:43Z

By request from Goobstation, I have added one of my signature "CVar Control Rooms" to Supermatter, adding 7 new CVars related to Supermatter.

Content.Shared/CCVar/CCVars.cs

Resources/Locale/en-US/objectives/conditions/steal.ftl

Resources/Locale/en-US/supermatter/supermatter.ftl

Resources/Prototypes/Entities/Mobs/Player/admin_ghost.yml

Resources/Prototypes/Entities/Objects/Misc/supermatter_sliver.yml

Resources/Prototypes/Guidebook/engineering.yml

Content.Server/Supermatter/Systems/SupermatterSystem.cs

Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: VMSolidus <[email protected]>

VMSolidus · 2024-08-02T23:57:53Z

Final update is complete, and I have tested supermatter ingame to verify that it works.

8mb.video-UdQ-XTe8cZxn.mp4

stale

whateverusername0 · 2024-08-03T08:33:31Z

chat we did it
we saved the station 🍾

# Description This refactors Geiger Counters so that their behavior of "Only making sound to a person holding them" is no longer hardcoded. The GeigerCounterComponent now can define how loud it ticks, how far away people can hear the ticks, and whether it plays only for the person holding it or for anyone nearby. This PR partially fulfills one of the "Nice To Have" features requested for #341 by making it possible to create stationary radiation alarm objects. It also serves as a substantial quality of life improvement for Engineering and Science crew, since it's now possible to place an active Geiger counter in the artifact lab, and then be able to audibly hear if the lab becomes radioactive due to an artifact. <details><summary><h1>Media</h1></summary> <p> https://github.com/user-attachments/assets/74122135-7345-4995-bb0e-d1216e1d53b6 https://github.com/user-attachments/assets/de79db6f-e1c1-471f-88b5-0a47ff4bfa16 </p> </details> # Changelog :cl: - add: Geiger Counters other than ones installed in Hardsuits now generate an audible sound when active and exposed to radiation. - add: Wall mounted geiger counters have been added to the game. --------- Signed-off-by: VMSolidus <[email protected]>

# Description This refactors Geiger Counters so that their behavior of "Only making sound to a person holding them" is no longer hardcoded. The GeigerCounterComponent now can define how loud it ticks, how far away people can hear the ticks, and whether it plays only for the person holding it or for anyone nearby. This PR partially fulfills one of the "Nice To Have" features requested for Simple-Station#341 by making it possible to create stationary radiation alarm objects. It also serves as a substantial quality of life improvement for Engineering and Science crew, since it's now possible to place an active Geiger counter in the artifact lab, and then be able to audibly hear if the lab becomes radioactive due to an artifact. <details><summary><h1>Media</h1></summary> <p> https://github.com/user-attachments/assets/74122135-7345-4995-bb0e-d1216e1d53b6 https://github.com/user-attachments/assets/de79db6f-e1c1-471f-88b5-0a47ff4bfa16 </p> </details> # Changelog :cl: - add: Geiger Counters other than ones installed in Hardsuits now generate an audible sound when active and exposed to radiation. - add: Wall mounted geiger counters have been added to the game. --------- Signed-off-by: VMSolidus <[email protected]>

Initial Port

4043f1b

github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files labels Apr 25, 2024

Should fix test fail

158b8d9

Edge with Experimental Supermatter Engine

7527bdd

github-actions bot added Changes: Map Changes any yml file in the Maps directories and removed Changes: YML Changes any yml files labels Apr 26, 2024

Update edge.yml

4089288

New edge by Colintel

a9d8b6b

VMSolidus added 3 commits April 26, 2024 19:04

Update edge.yml

bf337fe

Update edge.yml

07d94cb

better sound looping

0b428dc

DangerRevolution suggested changes Apr 30, 2024

View reviewed changes

DangerRevolution approved these changes Apr 30, 2024

View reviewed changes

Cleanup Deprecated VV Options

d67f005

Merge branch 'master' into Port-Of-Supermatter

7d93298

VMSolidus added Priority: 1-Urgent Must be resolved immediately and removed Priority: 2-High Needs to be resolved as soon as possible labels Jul 30, 2024

VMSolidus and others added 4 commits July 30, 2024 19:49

Update SupermatterSystem.cs

89e7d27

Update SupermatterFoodComponent.cs

af52d71

Update SupermatterComponent.cs

c1a5c57

Add job whitelist system (#28085)

db97eda

* Add job whitelist system * Address reviews * Fix name * Apply suggestions from code review Co-authored-by: Pieter-Jan Briers <[email protected]> * cancinium --------- Co-authored-by: Pieter-Jan Briers <[email protected]>

VMSolidus added 2 commits July 30, 2024 22:07

this is INTERESTING to learn

c54c778

Update SupermatterSystem.cs

7ede349

DEATHB4DEFEAT previously requested changes Aug 2, 2024

View reviewed changes

VMSolidus and others added 5 commits August 2, 2024 01:04

Apply suggestions from code review

f4f0d35

Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: VMSolidus <[email protected]>

Apply suggestions from code review

d999564

Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: VMSolidus <[email protected]>

Apply suggestions from code review

50ed86b

Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: VMSolidus <[email protected]>

Apply suggestions from code review

7f63471

Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: VMSolidus <[email protected]>

Final Update

1c76a1f

Update supermatter.yml

10989f4

OldDanceJacket approved these changes Aug 3, 2024

View reviewed changes

OldDanceJacket merged commit 80e48a5 into Simple-Station:master Aug 3, 2024
13 checks passed

SimpleStation14 added a commit that referenced this pull request Aug 3, 2024

Automatic Changelog Update (#341)

d5d3942

WarMechanic mentioned this pull request Aug 4, 2024

Port "Supermatter Engine" from EE DeltaV-Station/Delta-v#1578

Closed

1 task

VMSolidus mentioned this pull request Sep 25, 2024

Notice Of Copyright Violation Space-Stories/space-station-14#104

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Supermatter Engine (Port From White Dream) #341

Supermatter Engine (Port From White Dream) #341

VMSolidus commented Apr 25, 2024 •

edited

Loading

github-actions bot commented Apr 25, 2024 •

edited

Loading

VMSolidus commented Apr 25, 2024 •

edited

Loading

VMSolidus commented Apr 26, 2024

Colin-Tel commented Apr 26, 2024 •

edited

Loading

Colin-Tel commented Apr 26, 2024

VMSolidus commented Apr 26, 2024

DangerRevolution left a comment

DangerRevolution commented Apr 30, 2024

VMSolidus commented Apr 30, 2024

DangerRevolution commented Apr 30, 2024 •

edited

Loading

VMSolidus commented Apr 30, 2024

LovelyLophi commented Apr 30, 2024

DangerRevolution commented Apr 30, 2024

VMSolidus commented Apr 30, 2024

DangerRevolution left a comment

VMSolidus commented Apr 30, 2024

VMSolidus commented Jul 30, 2024

DEATHB4DEFEAT commented Jul 30, 2024

VMSolidus commented Jul 31, 2024

VMSolidus commented Aug 2, 2024

whateverusername0 commented Aug 3, 2024

Supermatter Engine (Port From White Dream) #341

Supermatter Engine (Port From White Dream) #341

Conversation

VMSolidus commented Apr 25, 2024 • edited Loading

Description

Changelog

github-actions bot commented Apr 25, 2024 • edited Loading

VMSolidus commented Apr 25, 2024 • edited Loading

TODO LIST:

VMSolidus commented Apr 26, 2024

Colin-Tel commented Apr 26, 2024 • edited Loading

Colin-Tel commented Apr 26, 2024

VMSolidus commented Apr 26, 2024

DangerRevolution left a comment

Choose a reason for hiding this comment

DangerRevolution commented Apr 30, 2024

VMSolidus commented Apr 30, 2024

DangerRevolution commented Apr 30, 2024 • edited Loading

VMSolidus commented Apr 30, 2024

LovelyLophi commented Apr 30, 2024

DangerRevolution commented Apr 30, 2024

VMSolidus commented Apr 30, 2024

DangerRevolution left a comment

Choose a reason for hiding this comment

VMSolidus commented Apr 30, 2024

VMSolidus commented Jul 30, 2024

DEATHB4DEFEAT commented Jul 30, 2024

VMSolidus commented Jul 31, 2024

VMSolidus commented Aug 2, 2024

whateverusername0 commented Aug 3, 2024

VMSolidus commented Apr 25, 2024 •

edited

Loading

github-actions bot commented Apr 25, 2024 •

edited

Loading

VMSolidus commented Apr 25, 2024 •

edited

Loading

Colin-Tel commented Apr 26, 2024 •

edited

Loading

DangerRevolution commented Apr 30, 2024 •

edited

Loading