Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Add Stealthmins #360

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26263: Add stealthmins from space-wizards space-wizards/space-station-14

dca0c6694bce56fcf962feab2b59ad4a849f4533

PR opened by nikthechampiongr at 2024-03-19 16:14:22 UTC


PR changed 11 files with 197 additions and 10 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

resolve #26013

About the PR

This pr implements stealthmins as laid out in issue #26013.

There is now the Stealth permission flag. This allows admins to use the stealthmin command and to see other stealthmins.

When stealthmin is toggled, the admin will not show up in adminwho except for other admins with the Stealth permission.

The stealthmin command sends fake de-admin/re-admin messages to admins without the Stealth flag.

stealthmin persists in the same way deadmin does(it persists for the lifetime of the server).

Admin login/logout messages are suppressed for stealthmins except for other admins with the Stealth flag.

It is still possible possible to find stealthed admins using toolshed commands or logs. This is in line with the requirements of the issue, and I don't want to start clobbering functionality of logs and toolshed.

Why / Balance

See #26013

Technical details

Stealth flag now exist for AdminFlags.

An admin's stealth status is saved in their admin registration and in ContentData.

SendAdminAnnouncement now takes a whitelist flag and blacklist flag (This will work with multiple flags). This is necessary to suppress admin announcements where necessary. Blacklist takes priority over whitelist.

Media

2024-03-19.17-03-34.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑
ADMIN:

  • add: The stealthmin command has been added. Admins with the Stealth permission can now hide themselves from adminwho except for other admins with that permission.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label May 3, 2024
@VMSolidus VMSolidus marked this pull request as ready for review May 5, 2024 19:27
@DangerRevolution DangerRevolution added the Changes: C# Changes any cs files label May 11, 2024
@github-actions github-actions bot added the Status: Needs Review Someone please review this label May 11, 2024
@DangerRevolution DangerRevolution added Changes: Localization Changes any ftl files Changes: Config Changes any configuration files Size: 3-Medium For medium issues/PRs Priority: 3-Medium Needs to be resolved at some point Status: Needs Cleanup Someone has to clean this before merging Status: Help Wanted Extra attention is needed Type: Feature Creation of or significant changes to a feature labels May 11, 2024
@github-actions github-actions bot removed the Changes: Config Changes any configuration files label May 29, 2024
@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Jun 11, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@DEATHB4DEFEAT DEATHB4DEFEAT changed the title Mirror: Add stealthmins Mirror: Add Stealthmins Jul 12, 2024
@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Jul 12, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT merged commit e6779b6 into Simple-Station:master Jul 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Priority: 3-Medium Needs to be resolved at some point Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot Size: 3-Medium For medium issues/PRs Status: Help Wanted Extra attention is needed Status: Needs Cleanup Someone has to clean this before merging Status: Needs Review Someone please review this Type: Feature Creation of or significant changes to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants