Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Church Bells #388

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26030: Church Bells from space-wizards space-wizards/space-station-14

a0cc87c2673bc0930adafe9ab8650700d8ecf2e3

PR opened by SphiraI at 2024-03-12 08:33:08 UTC


PR changed 9 files with 68 additions and 0 deletions.

The PR had the following labels:

  • No C#
  • Changes: Sprites
  • Status: Awaiting Changes

Original Body

About the PR

  • Adds a church bell to be used with station chapels
    idea and sprites by Kezu, proto/sounds put together by me.

Why / Balance

"if the jani gets their jani light for convenience and rp, the chapel gets a church bell to signal for sermons" -Kezu
RP purposes, and to give something to chap similar to something like Clown's horn. Would let Chaps use it to get passerby's attention and whatnot.

Media

image

There is a .ogg sound added, but I'm not sure how to make it play nice with git, please someone bwoink me with how

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑 Sphiral&Kezu

  • add: Added Church Bells! You may hear otherworldly chimes near your local chapel soon...

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label May 3, 2024
Copy link
Contributor

github-actions bot commented May 3, 2024

RSI Diff Bot; head commit 5f6feac merging into b68ed3c
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Specific/church-bell.rsi

State Old New Status
church-bell Added

@DangerRevolution DangerRevolution marked this pull request as ready for review May 4, 2024 21:49
@DangerRevolution DangerRevolution self-assigned this May 4, 2024
@DangerRevolution DangerRevolution added Changes: YML Changes any yml files Priority: 4-Low Should be resolved at some point Changes: Sprite Changes any png or json in an RSI Size: 5-Very Small For especially small issues/PRs Type: Feature Creation of or significant changes to a feature labels May 4, 2024
layers:
- state: church-bell
- type: InteractionPopup
interactDelay: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably be slower to stop spam

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that a wooden pole? might look weird in a space station, i wanna see this in game first.

Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving

people said this looks okay, and it's not like I could draw a better version lol

@VMSolidus VMSolidus merged commit f525ea7 into Simple-Station:master May 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Priority: 4-Low Should be resolved at some point Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot Size: 5-Very Small For especially small issues/PRs Type: Feature Creation of or significant changes to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants