Alternate Corporate Coats Wave 1 #392
Conversation
github-actions
bot
added
Changes: Sprite
|
RSI Diff Bot; head commit f6d2035 merging into 156dfb6 Resources/Textures/Clothing/OuterClothing/WinterCoats/cs_corpo_jacket.rsi
Resources/Textures/Clothing/OuterClothing/WinterCoats/ee_corpo_jacket.rsi
Resources/Textures/Clothing/OuterClothing/WinterCoats/hi_corpo_jacket.rsi
Resources/Textures/Clothing/OuterClothing/WinterCoats/hm_corpo_jacket.rsi
Resources/Textures/Clothing/OuterClothing/WinterCoats/id_corpo_jacket.rsi
|
|
I see the failure, give me a moment. |
Co-authored-by: DEATHB4DEFEAT <[email protected]>
There was a problem hiding this comment.
Very cool, they look nice; just a question on the meta.json's and
Going to ask for these to be localized in .ftl, which lets downstreams alter the descriptions of these without making merge conflicts for purposes such as translation for our Ukranian fork and altering the description for Syndicate-focused fork so it makes sense in their lore.
| ClothingOuterEECorporateJacket: 2 # Einstein Engines - Clothing addition | ||
| ClothingOuterHICorporateJacket: 2 # Einstein Engines - Clothing addition | ||
| ClothingOuterHMCorporateJacket: 2 # Einstein Engines - Clothing addition | ||
| ClothingOuterIdCorporateJacket: 2 # Einstein Engines - Clothing addition |
There was a problem hiding this comment.
Tags are fine here as it's in the middle of many other non-Wiz clothes.
| { | ||
| "version": 1, | ||
| "license": "CC-BY-SA-3.0", | ||
| "copyright": "Leonardo DaBepis#4869 on discord / @leonardo-dabepis on Tumblr", |
There was a problem hiding this comment.
Did you draw this or did Leo?
There was a problem hiding this comment.
Leo created the original jacket, I merely edited them to match the color schemes
There was a problem hiding this comment.
you need to credit yourself for the edit
@DangerRevolution I have no idea how to do FTL files so I think I'll leave that for other people if they want to pick this up. I'd prefer if there were some solid requirements for what a PR needs that I could read somewhere. |
Very real, localisation should probably be done by script when that's made one day. Standards are something we still have to decide on really, not really sure. |
|
if you fix the credit by adding your name in i'll approve the review |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
they pass, just a microsoft issue |
Pspritechologist
merged commit 8d6c536
into
Simple-Station:master
Description
Edited the corporate coat by Leonardo DaBepis,
Thought we could have some more options for assistant gang colors. /j
Media
WAOW THEY LOOK SO COOOL RIGHT?
Changelog
🆑