Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glorious Canisters #406

Merged

Conversation

FoxxoTrystan
Copy link
Member

@FoxxoTrystan FoxxoTrystan commented May 14, 2024

Description

Changed the Canisters Sprites to a better updated one, no more ugly 2D Flat Canisters!
Also update the TG Sprite from Tank Canisters now shiny!


Media

image
image


Changelog

🆑

  • tweak: Resprited gas canisters
  • tweak: Resprited gas tanks

@github-actions github-actions bot added the Changes: Sprite Changes any png or json in an RSI label May 14, 2024
Copy link
Contributor

github-actions bot commented May 14, 2024

RSI Diff Bot; head commit 6204bc4 merging into 23c0e98
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Tanks/anesthetic.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Tanks/emergency.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Tanks/emergency_double.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Tanks/emergency_double_red.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Tanks/emergency_extended.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Tanks/emergency_extended_red.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Tanks/emergency_red.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Tanks/emergency_yellow.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Tanks/generic.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Tanks/oxygen.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Tanks/plasma.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Tanks/red.rsi

State Old New Status
icon Modified

Resources/Textures/Structures/Storage/canister.rsi

State Old New Status
black-1 Modified
black Modified
blue-1 Modified
blue Modified
can-connector Modified
can-o0 Modified
can-o1 Modified
can-o2 Modified
can-o3 Modified
can-oa1 Modified
can-open Modified
darkblue-1 Modified
darkblue Modified
frezon-1 Modified
frezon Modified
grey-1 Modified
grey Modified
orange-1 Modified
orange Modified
red-1 Modified
red Modified
redws-1 Modified
redws Modified
water_vapor-1 Modified
water_vapor Modified
yellow-1 Modified
yellow Modified

Edit: diff updated after 6204bc4

Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually good sprites, on my Repo? Woah!

@DEATHB4DEFEAT
Copy link
Member

The gas tank sprites look way too bright (oversaturated?), canisters look great though.

Also read the PR template next time, you left a ton of unnecessary stuff it asked you to remove.

@VMSolidus
Copy link
Member

The gas tank sprites look way too bright (oversaturated?), canisters look great though.

Also read the PR template next time, you left a ton of unnecessary stuff it asked you to remove.

Oh, yea I see what you mean. If Trystan will let me, I can go over the sprites with weathering effects and make them fit better.

@FoxxoTrystan
Copy link
Member Author

FoxxoTrystan commented May 15, 2024

The gas tank sprites look way too bright (oversaturated?), canisters look great though.
Also read the PR template next time, you left a ton of unnecessary stuff it asked you to remove.

Oh, yea I see what you mean. If Trystan will let me, I can go over the sprites with weathering effects and make them fit better.

Go on and proceed!
Do note that i have disabled lighting during the screenshot above.

@DangerRevolution
Copy link
Contributor

This should be drafted if VM is editing these.

@FoxxoTrystan FoxxoTrystan marked this pull request as draft May 20, 2024 23:00
@github-actions github-actions bot added the Status: Needs Review Someone please review this label May 28, 2024
@DangerRevolution DangerRevolution added the Priority: 4-Low Should be resolved at some point label May 28, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks alright, i approve, re-requested new VM review

@VMSolidus VMSolidus marked this pull request as ready for review May 31, 2024 00:09
@VMSolidus
Copy link
Member

I have finished editing the tanks after a long hiatus

@DangerRevolution DangerRevolution enabled auto-merge (squash) May 31, 2024 00:11
@DangerRevolution DangerRevolution merged commit d684fb6 into Simple-Station:master May 31, 2024
10 checks passed
SimpleStation14 added a commit that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an RSI Priority: 4-Low Should be resolved at some point Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants