Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harpy Peacock Tail #428

Merged
merged 9 commits into from
Jun 20, 2024
Merged

Harpy Peacock Tail #428

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
770a2b0
YE
VMSolidus May 31, 2024
5dceb82
Merge branch 'master' into Harpy-Markings-Wave-2
VMSolidus Jun 15, 2024
8e61fc8
Update Resources/Textures/DeltaV/Mobs/Customization/Harpy/harpy_tails…
VMSolidus Jun 15, 2024
acf2ae3
That's right, I'm their maintainer, and I maintain them here now
VMSolidus Jun 15, 2024
4a251af
Update harpy.yml
VMSolidus Jun 15, 2024
777698d
renaming folders
VMSolidus Jun 16, 2024
4022a47
Merge branch 'master' into Harpy-Markings-Wave-2
VMSolidus Jun 17, 2024
3ae0a5e
Update harpy.yml
VMSolidus Jun 19, 2024
5de2a6a
Update harpy.yml
VMSolidus Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Resources/Locale/en-US/deltav/markings/harpy.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ marking-HarpyTailRooster-rooster_tail = Tail
marking-HarpyTailFinch = Finch Tail
marking-HarpyTailFinch-finch_tail = Tail

marking-HarpyTailPeacock = Peacock Tail
marking-HarpyTailPeacock-peacock_tail_feathers = Feathers
marking-HarpyTailPeacock-peacock_tail_eyes = Eyes

marking-HarpyChestDefault = Wing & Groin Under-Clothes
marking-HarpyChestDefault-upper = Wing Under-Clothes
marking-HarpyChestDefault-lower = Groin Under-Clothes
Expand Down
20 changes: 19 additions & 1 deletion Resources/Prototypes/DeltaV/Entities/Mobs/Customization/Markings/harpy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,25 @@
- !type:SimpleColoring
sprites:
- sprite: DeltaV/Mobs/Customization/Harpy/harpy_tailsx72.rsi
state: finch_tail
state: finch_tail

- type: marking
id: HarpyTailPeacock
bodyPart: Tail
markingCategory: Tail
speciesRestriction: [Harpy]
coloring:
default:
type:
!type:CategoryColoring
category: Hair
fallbackTypes:
- !type:SimpleColoring
sprites:
- sprite: DeltaV/Mobs/Customization/Harpy/harpy_tailsx96.rsi
state: peacock_tail_feathers
- sprite: DeltaV/Mobs/Customization/Harpy/harpy_tailsx96.rsi
state: peacock_tail_eyes

- type: marking
id: HarpyWing2ToneClassic
Expand Down
9 changes: 8 additions & 1 deletion Resources/Prototypes/DeltaV/Entities/Mobs/Species/harpy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
"Acoustic": {24: 0}
"Flute": {73: 0}
"Sax": {66: 0}
"Piano": {1: 0}
"Church Organ": {19: 0}
VMSolidus marked this conversation as resolved.
Show resolved Hide resolved
- type: UserInterface
interfaces:
- key: enum.InstrumentUiKey.Key
Expand Down Expand Up @@ -54,7 +56,6 @@
visible: false
- map: [ "id" ]
- map: [ "gloves" ]
- map: [ "shoes" ]
- map: [ "ears" ]
- map: [ "outerClothing" ]
- map: [ "eyes" ]
Expand Down Expand Up @@ -127,6 +128,12 @@
templateId: digitigrade
- type: HarpyVisuals
- type: UltraVision
- type: Tag
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do? Don't they inherit this from basemob?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I add ANY tags, I now have to copy the entire BaseHuman tag component. Because tags aren't inherited for stupid reasons. I'm adding the NoStepShoesRequired tag for Harpies because I removed their shoes slot. This tag is a little stupidly named, but all it does it make it so that they don't get stunned by walking over glass shards. I assume the birbs with their tiny light feet just tip-claw around the shards, unlike how a clumsy human might stomp right into them.

tags:
- CanPilot
- FootstepSound
- DoorBumpOpener
- ShoesRequiredStepTriggerImmune

- type: entity
save: false
Expand Down
7 changes: 0 additions & 7 deletions Resources/Prototypes/DeltaV/InventoryTemplates/digitigrade_inventory_template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,6 @@
- type: inventoryTemplate
id: digitigrade
slots:
- name: shoes
slotTexture: shoes
slotFlags: FEET
stripTime: 3
uiWindowPos: 1,0
strippingWindowPos: 1,3
displayName: Shoes
- name: jumpsuit
slotTexture: uniform
slotFlags: INNERCLOTHING
Expand Down
19 changes: 19 additions & 0 deletions Resources/Textures/DeltaV/Mobs/Customization/Harpy/harpy_tailsx96.rsi/meta.json
View file
Open in desktop
VMSolidus marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"version": 1,
"license": "CC-BY-SA-3.0",
"copyright": "Peacock by @stillxicarus",
VMSolidus marked this conversation as resolved.
Show resolved Hide resolved
"size": {
"x": 48,
"y": 48
},
"states": [
{
"name": "peacock_tail_feathers",
"directions": 4
},
{
"name": "peacock_tail_eyes",
"directions": 4
}
]
}
Binary file added ...xtures/DeltaV/Mobs/Customization/Harpy/harpy_tailsx96.rsi/peacock_tail_eyes.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...es/DeltaV/Mobs/Customization/Harpy/harpy_tailsx96.rsi/peacock_tail_feathers.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading