Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to Separated UI Layout #433

Merged
merged 3 commits into from
Jun 16, 2024

Conversation

DEATHB4DEFEAT
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT commented Jun 3, 2024

Description

Change from Nyano
Uses space a lot better. The old layout still exists if people want it for whatever reason.
I also renamed "Default" to "Overlay", which should stay anyway if the default change is denied.


Media

Separated

image

Overlay

image


Changelog

🆑

  • tweak: UI layout now defaults to separated, the old one is still available in settings

@DEATHB4DEFEAT DEATHB4DEFEAT added Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Status: Needs Discussion Must be discussed Type: Cleanup Like Rework but small labels Jun 3, 2024
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: UI Changes any XAML files labels Jun 3, 2024
@DangerRevolution DangerRevolution enabled auto-merge (squash) June 8, 2024 21:33
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind including screenshots of the two different UIs, so that we can see in the PR the differences visually of what's being changed?

@DEATHB4DEFEAT
Copy link
Member Author

Do you mind including screenshots of the two different UIs, so that we can see in the PR the differences visually of what's being changed?

Done.

Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH. Yea that's a significant improvement.

@VMSolidus VMSolidus merged commit 544fd13 into Simple-Station:master Jun 16, 2024
11 checks passed
SimpleStation14 added a commit that referenced this pull request Jun 16, 2024
VMSolidus pushed a commit to VMSolidus/Einstein-Engines that referenced this pull request Jun 21, 2024
# Description

<sub>~~Change from Nyano~~</sub>
Uses space a lot better. The old layout still exists if people want it
for whatever reason.
I also renamed "Default" to "Overlay", which should stay anyway if the
default change is denied.

---

<details><summary><h1>Media</h1></summary>
<p>

## Separated


![image](https://github.com/Simple-Station/Einstein-Engines/assets/77995199/b97c4373-99ac-4ac5-80a5-149122238551)

## Overlay


![image](https://github.com/Simple-Station/Einstein-Engines/assets/77995199/3891756f-91f0-4336-b075-6c461ee1b8e6)

</p>
</details>

---

# Changelog

:cl:
- tweak: UI layout now defaults to separated, the old one is still
available in settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: UI Changes any XAML files Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this Type: Cleanup Like Rework but small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants