Sign Language! #439
Closed
Sign Language! #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: C#
|
Make a better changelog. |
There, tho note that its not added to any specie by default, mostly by the trait/menu, ect... |
DEATHB4DEFEAT
requested changes
Jun 10, 2024
| @@ -31,6 +31,14 @@ | |||
| - nah | |||
| - wah | |||
|
|
|||
| # The common galactic Sign Language! | |||
There was a problem hiding this comment.
Suggested change
| # The common galactic Sign Language! |
| signLanguage: true | ||
| obfuscateSyllables: false | ||
| replacement: | ||
| - "*incomprehensible*" |
There was a problem hiding this comment.
Put some things like these
Suggested change
| - "*incomprehensible*" | |
| - signs something | |
| - makes weird hand gestures |
There was a problem hiding this comment.
Replacement is never heart its is just a placeholder for Replacement value.
There was a problem hiding this comment.
Its uses .ftl files.
I cannot translate replacement.
There was a problem hiding this comment.
All of these should be localized but this one prototype shouldn't be any different from any other.
DangerRevolution
approved these changes
Jun 11, 2024
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: FoxxoTrystan <[email protected]>
DangerRevolution
added
Size: 3-Medium
|
Will be remade under the Refactor: #459 Closed. |
|
PR moved to #553 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gives a new way to speak, Sign Languages using the Language system by only adding a nullable variable.
Sign Language uses the default Emote system, meaning its will not get picked up by Radio or others devices or get blocked by accents.
When a Sign Language is on, "Say/Whisper" will talk in Sign Language, Emote will still act like normal emotes.
The Glorious Sign Language has arrived... and there can be more then one!
PR MOVED TO #553
Media
Changelog
🆑