Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror 26383: Fix mailing units turning into disposal units while recharging. #441

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26383: Fix mailing units turning into disposal units while recharging. from space-wizards space-wizards/space-station-14

94e4755a8de6885c97fac1cfb767144e8e07981a

PR opened by nikthechampiongr at 2024-03-24 11:57:45 UTC - merged at 2024-03-25 13:20:39 UTC


PR changed 2 files with 14 additions and 3 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

fixes #18275

About the PR

This fixes mailing units appearing as disposal units when flushed.

Technical details

The states were hardcoded.

Now they are not.

Bug seems to have been introduced in #17803 as a part of a larger refactor on disposal units. To my understanding, this was made in error with the logic that no other objects would ever have a different animation when flushing and charging but I am not sure.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • fix: Mailing units no longer spontaneously turn into disposal units when flushed.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Jun 11, 2024
@Pspritechologist Pspritechologist added Status: Derelict Has not been active for a while and removed Status: Derelict Has not been active for a while labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot Status: Derelict Has not been active for a while
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants