Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror 25908: Chat Censorship Systems #444

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #25908: SS14-17313 Chatfactor: Chat Censorship Systems from space-wizards space-wizards/space-station-14

bf98a6a8bb2a57fb149459d6b053eaaf6abc8cd7

PR opened by FairlySadPanda at 2024-03-07 12:13:16 UTC - merged at 2024-03-25 23:50:20 UTC


PR changed 4 files with 576 additions and 0 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

About the PR

Adds some systems to manage chat censorship:

  1. No-op: does nothing
  2. SimpleCensor: a regex-free censor with a variety of rules to use
  3. RegexCensor: a censor that uses regex.

This exposes a singleton backed by a builder pattern (ChatCensor) that is set up, probably during the code init phase, and then globally available for your censorship needs.

Why / Balance

Partial fulfilment of #17313

Technical details

CE wants regex, CE gets regex

Otherwise SimpleCensor is designed to be usable by people who don't want to faff with regex.

This would be setup during server or client init, so would be driven by Cvars.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

nope
Changelog
nope

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Jun 11, 2024
@Pspritechologist Pspritechologist added Status: Derelict Has not been active for a while and removed Status: Derelict Has not been active for a while labels Jun 11, 2024
@VMSolidus VMSolidus marked this pull request as ready for review June 12, 2024 16:36
@github-actions github-actions bot added Status: Needs Review Someone please review this labels Jun 14, 2024
@DangerRevolution DangerRevolution added Priority: 4-Low Should be resolved at some point Size: 3-Medium For medium issues/PRs Status: Needs Discussion Must be discussed Type: Feature Creation of or significant changes to a feature Type: Port Brings something to here from another codebase Changes: C# Changes any cs files Changes: Config Changes any configuration files labels Jun 14, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title Mirror 25908: SS14-17313 Chatfactor: Chat Censorship Systems Mirror 25908: Chat Censorship Systems Jul 12, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT merged commit 19568f7 into Simple-Station:master Jul 12, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Config Changes any configuration files Priority: 4-Low Should be resolved at some point Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot Size: 3-Medium For medium issues/PRs Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this Type: Feature Creation of or significant changes to a feature Type: Port Brings something to here from another codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants